Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper name for bookmark assets in admin #708

Merged

Conversation

ab623
Copy link
Contributor

@ab623 ab623 commented Apr 17, 2024

When viewing the detail of a BookmarkAsset in the admin panel, it shows as the default object string.

image

I have added a very basic string method, which uses the display_name or if that is not present (as its not mandatory), defaults to a simple string.

With no display_name
image

With display_name
image

This is also reflected on the list page also

image

@sissbruecker sissbruecker changed the title Implemented a default display name for the BookmarkAsset model Show proper name for bookmark assets in admin Apr 17, 2024
@sissbruecker sissbruecker merged commit 0586983 into sissbruecker:master Apr 17, 2024
2 checks passed
@sissbruecker
Copy link
Owner

Makes sense, thanks!

@ab623 ab623 deleted the fix-update-bookmarkasset-admin branch April 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants