Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable form login #972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyuuk
Copy link
Contributor

@kyuuk kyuuk commented Jan 30, 2025

Fixes #730

Add an option to disable login form, this hides the username and password fields and Login button,
i also changed the Login with OIDC button css classes to make it a little better when form is disabled
which gives a for like this :
image

i'm not sure about the frontend part , it could probably be improved.

  • Added test to validate that by default fiels are still present
  • Added test to validate that fields are not present when option is true

@kyuuk kyuuk marked this pull request as ready for review January 30, 2025 10:13
@sissbruecker
Copy link
Owner

Reading through #730 again, I don't think the intention is to hide the login form. The goal is to automatically initiate the OIDC flow when opening the app without having to click a button on the login page.

@kyuuk
Copy link
Contributor Author

kyuuk commented Jan 30, 2025

I saw that also, but understood that it was a separate optional feature.

I’m thinking of implementing that also, but i don't want to mess too much as i'm not good with frontend.

I’ll try asking in #730 if someone can help with this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Local Login After Enabling Authentik OIDC
2 participants