Adds the option to fetch metadata to imports #979
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Feb 3, 2025
| bookmarks_to_create + bookmarks_to_update, | ||
| ) | ||
|
|
||
| with ThreadPoolExecutor(5) as executor: |
There was a problem hiding this comment.
This should be a background task instead, you can check bookmarks/services/tasks.py as a reference for existing ones. So you could add a new task there, then schedule one per bookmark from here.
Tests would be welcome as well, test_bookmarks_tasks.py is used for testing tasks themselves, and test_importer.py could test that the task is called on import.
There was a problem hiding this comment.
This can be reverted when adding the background task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the same request as #952, so I implemented it in case anyone else does too!
Quickly testing with 177 imported bookmarks (all with missing fields) took ~20 seconds (85 seconds without the threading).