Refactoring & bug-fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(will also be done for user-client)
Added missing Concerns to Review Page Improved Layout
added config.js support
renamed Reviews to Reviewers
regarding renamed reviewers
added „general_comment“ and „reviewer(s)“ to submission-view
Added attribute „updated“ to Revisions to show the submitted timestamp inside the user-/admin-clients
- integrated navController inside mainController - fixed promises in documentDetailsController - fixed editDocument-template
- updated apiControllers - updated routes - updated queries
(still in progress)
refactored all text on site into languages.js
Fixed infinite loading screen after User Creation.
(still in progress)
rephrased to proper English.
Conflicts: public/member-client/js/modules/languages.js
- Moved the "Start Review"/"Open Review" Buttons to top of the page - Added subtitles to Files at download (provided by fhillen)
- deleted config.js and replaced it with an .env-file, following the dotenv-guidline - Code-cleaning - bug-fixes in email-templates and notifications
- Added path variables for the member- & user-client to the .env file - Fixed email-templates - Updated README
Updated languages.js and related controllers in user- and member-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.