Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

Align new 9.1.1 XM images with existing ones #28

Closed
sshushliapin opened this issue Apr 8, 2019 · 2 comments
Closed

Align new 9.1.1 XM images with existing ones #28

sshushliapin opened this issue Apr 8, 2019 · 2 comments

Comments

@sshushliapin
Copy link
Contributor

Thank you for adding 9.1.1 support! From the recent release notes:

[Added] Sitecore 9.1.1 XM and XP on ltsc2019/1809, please notice that the xm1 tags is now just xm

Is there any reason for this? Does it make sense to align the naming conventions and rename all the existing xm1 images into xm (or vice versa)?

Currently I'm using docker hub with 20 repositories ($22/month) to build 9.x images. 9.1.1 introduces 3 new xm repos that do not feet my plan and force me to either switch to the next one ($50) or to configure local registry (which I'd like to avoid).

Please let me know if I should come up with a PR fixing this.

@pbering
Copy link
Contributor

pbering commented Apr 8, 2019

I'm sorry that I didn't foresee the consequences of this rename for those of you using the "pay per repository" model!

I think that it would be best to go back to using xm1 instead of changing all the other to xm. The reason why I chose xm1 to begin with was to reflect which package it came from and that is also why xp is only xp since it's a mix of both xp0 and xp1 :)

What do you say?

@sshushliapin
Copy link
Contributor Author

sshushliapin commented Apr 8, 2019

The reason why I chose xm1 to begin with was to reflect which package it came from

+1. I'd change it to xm1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants