-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong exit status when testing URLs that do not work #1267
Comments
Looks like this is caused by https://github.com/sitespeedio/sitespeed.io/blob/master/bin/sitespeed.js#L39 being undefined by default. Maybe we should had a default budget that the initial URL must load with a 2xx or 3xx. |
good, that is one thing: that check should only run when we configured a budget, I'll fix that first. |
I think we can just check for errors in the budget, I've missed that when I implemented it. |
no that will not work :) lets think about it for a while. |
We possible might need something upstream returned in browsertime for the status of the initial URL. The returned object here doesn't know about the failed URL. |
Yes. I think there's an issue to add an error element in the JSON from Browsertime, but it will be some work so it has been put aside. One ugly solution for now could be to compare number of URLs in the budget and the ones tested or something like that. |
Do you think it would be possible to somehow check for the test URL failing to load in the --browsertime.preScript and do something in the script to stop the test? If so, what could we do to stop the sitespeed.io process from within the preScript? I'm basically looking for a way to get notified when a Jenkins job running sitespeed.io against a URL fails because the target site is not up. Currently, as per above, the exit code returned is still 0 for v5.6.5:
|
@jchoksi-whitbread I've totally missed this one, next week I'll work 100% with sitespeed.io projects, I'll fix this then. |
This was pushed in 6.0, it catches if one of the URLs fail. However we still have work 2do to make sure some errors give right exit code. |
@soulgalore Can't find another similar issue, maybe there are some updates here
|
The text was updated successfully, but these errors were encountered: