Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox CPU Power Consumption values have incorrect units (µWh instead of Wh) #4333

Closed
canova opened this issue Dec 9, 2024 · 1 comment

Comments

@canova
Copy link

canova commented Dec 9, 2024

I was looking into #4329 and realized that the power consumption values have incorrect units. It should be Wh and not µWh.

The same STR with #4329 can be used for testing.

For example it shows 0.0036 µWh in a report on my machine, but it should be 0.0036 Wh (or better yet, 3.6 mWh).

Inside the Firefox Profiler we also have a logic to choose the best unit depending on the value:
https://github.com/firefox-devtools/profiler/blob/6306555856f9c5b1f539462f24c182b7c07d477b/src/components/tooltip/TrackPower.js#L84-L115

So this way the unit is always readable/meaningful to the user. But I don't know how easy it is to implement something similar here.

@soulgalore
Copy link
Member

Hi @canova ooops, thanks! Let me fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants