Add wpt metrics #1871
Add wpt metrics #1871
Conversation
| @@ -94,6 +94,9 @@ WebPageTest | |||
| --webpagetest.script The WebPageTest script as a string. | |||
| --webpagetest.includeRepeatView Do repeat or single views [boolean] [default: false] | |||
| --webpagetest.private Wanna keep the runs private or not [boolean] [default: true] | |||
| --webpagetest.timeline Activates chrome tracing. More Useful metrics but can slow down the test itself [boolean] [default: false] | |||
| --webpagetest.domainsDashboard Record weight and requests for each domain to populate the grafana dashboard. Will take more disk space in graphite [boolean] [default: false] | |||
There was a problem hiding this comment.
We send over all webpagetest.* metrics to the WebPageTest API, I think maybe we should mark the ones that are sitespeed.io own, so it makes it easier to understand. @tobli @beenanner any input?
There was a problem hiding this comment.
I mean webpagetest.domainsDashboard :)
There was a problem hiding this comment.
Yeah I thought about deleting the option once it has been used in index.js, but modifying the options directly is never a good idea.
Later on, I would like to add a connection alias (rather than "custom") for WPT, so the same problem will occur.
Maybe we should add a sub namespace, like
--webpagetest.ssio.enableDomains=…
--webpagetest.ssio.connectivityAlias=…
There was a problem hiding this comment.
Yes, either that or adding --webpagetestParams (following the same patterns as we have for some others)? The thing with the WebPageTest NodeJS API is that it changes options passed into it but if I remember correctly we "fixed" that by passing a copy of the object to the api.
Thinking some more, if you add the .ssio and then we could remove it from the cloned version here: https://github.com/sitespeedio/sitespeed.io/blob/master/lib/plugins/webpagetest/analyzer.js#L23
There was a problem hiding this comment.
you're the architect, tell me what would fit best
There was a problem hiding this comment.
I want input from @beenanner and @tobli :)
|
@jpvincent Looks great, thanks this will be really cool! Only thing is that extra parameter, let us sync that and then merge. |
|
Let me merge it, add the sub name space and then let it run for a while on dashboard.sitespeed.io and we can add your new dashboards. |
|
Thanks again @jpvincent of for the cool contribution :) |
|
I've put the domainsDashboard under -webpagetest.ssio.domainsDashboard but keep it out of the docs and cli for now (like a hidden feature). |
| 'data.median.firstView.visualComplete95', | ||
| 'data.median.firstView.visualComplete99', | ||
| 'data.median.firstView.FirstInteractive', | ||
| 'data.median.firstView.TimeToInteractive', |
There was a problem hiding this comment.
does this prevent the data from repeat view to be processed? because it explicitly says data.media.firstView... now, instead of data.median.*...
There was a problem hiding this comment.
ooops, you are right, we changed the default behavior there, let me fix that. Usually I only test first view but we shouldn't change how we collect metrics.
Your checklist for a pull request to sitespeed.io
Please review the guidelines for contributing to this repository.
npm testand test linting bynpm run lintDescription
Please describe your pull request and tell us the fix #
Following the new WPT grafana dashboards (sitespeedio/grafana-bootstrap-docker#14), and as requested by @soulgalore here is my proposal to add more metrics from WPT to grafana.
For the demo to work correctly, please activate the
webpagetest.timelineoption (was already there) and the newly addedwebpagetest.domainsDashboard.I also updated the documentation accordingly, tell me if all looks right.