Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF7Text: Process Remaining Characters #133

Merged
merged 1 commit into from
Jul 17, 2023
Merged

FF7Text: Process Remaining Characters #133

merged 1 commit into from
Jul 17, 2023
+360 −94

Conversation

sithlord48
Copy link
Owner

@sithlord48 sithlord48 commented Jul 2, 2023 •
edited
Loading

  • Handle All the Characters via FF7Text
  • Special Handling of 0xFEE2 (memory...)
  • Special Handling of 0xFEDD {PAUSE%1}

@myst6re Please check this over

@sithlord48 sithlord48 requested a review from myst6re July 2, 2023 21:32
@sithlord48 sithlord48 changed the title FF7Text: Handle Remaining strings Draft: FF7Text Changes Jul 3, 2023
@sithlord48 sithlord48 marked this pull request as draft July 3, 2023 00:29
@sithlord48 sithlord48 force-pushed the betterFF7Text branch 2 times, most recently from 44cf335 to c3e1e37 Compare July 3, 2023 06:22
@sithlord48 sithlord48 force-pushed the betterFF7Text branch 4 times, most recently from 1a22edb to d5cb709 Compare July 15, 2023 17:24
myst6re
myst6re reviewed Jul 15, 2023
View reviewed changes
src/data/FF7Text.cpp Outdated Show resolved Hide resolved
src/data/FF7Text.cpp Outdated Show resolved Hide resolved
src/data/FF7Text.cpp Outdated Show resolved Hide resolved
src/data/FF7Text.cpp Outdated Show resolved Hide resolved
src/data/FF7Text.cpp Outdated Show resolved Hide resolved
@sithlord48 sithlord48 force-pushed the betterFF7Text branch 2 times, most recently from 8168be2 to 7e2929b Compare July 16, 2023 01:45
@sithlord48 sithlord48 changed the title Draft: FF7Text Changes FF7Text: Process Remaining Characters Jul 16, 2023
@sithlord48 sithlord48 requested a review from myst6re July 16, 2023 01:47
@sithlord48 sithlord48 marked this pull request as ready for review July 17, 2023 08:56
@sithlord48 sithlord48 merged commit 2f1df67 into master Jul 17, 2023
@sithlord48 sithlord48 deleted the betterFF7Text branch July 17, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myst6re myst6re Awaiting requested review from myst6re

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sithlord48 @myst6re