Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feature to remove duplicated images and update database #9

Merged
merged 8 commits into from
Jun 6, 2021
Merged

Added feature to remove duplicated images and update database #9

merged 8 commits into from
Jun 6, 2021

Conversation

peterjaap
Copy link
Contributor

No description provided.

@peterjaap
Copy link
Contributor Author

This PR also includes the changes in #7 and #8

@peterjaap peterjaap changed the title Added flag to remove duplicated images and update database Added feature to remove duplicated images and update database Oct 8, 2020
@peterjaap
Copy link
Contributor Author

My local test;

8228 duplicated files have been deleted
0 rows have been updated in the catalog_product_entity_varchar table
26333 rows have been updated in the catalog_product_entity_media_gallery table
764 Mb has been freed.

sivaschenko
sivaschenko requested changes Oct 12, 2020
View reviewed changes
Copy link
Owner

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the contributions @peterjaap ! Please see my improvement suggestions.

Service/DuplicateFileFinder.php Outdated Show resolved Hide resolved
Command/CatalogMedia.php Outdated Show resolved Hide resolved
@peterjaap
Copy link
Contributor Author

@sivaschenko could you take a look at this PR again please?

@sivaschenko
Copy link
Owner

Refactored the implementation and introduced a separate command for duplicates.
Need to test the PR and update README before merging

@peterjaap
Copy link
Contributor Author

@sivaschenko nice, LGTM! 👍

@sivaschenko sivaschenko merged commit e25d1bb into sivaschenko:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjaap @sivaschenko