Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic purge for local data repo #13091

Closed
TCOTC opened this issue Nov 8, 2024 · 19 comments
Closed

Automatic purge for local data repo #13091

TCOTC opened this issue Nov 8, 2024 · 19 comments
Assignees
Milestone

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Nov 8, 2024

在一定的时间间隔内保存指定数量的未标记的快照,如:

  • 1 天内:无限制
  • 2~3 天内:20 个快照(比如 2~3 天内有 100 个快照,就每删 4 个快照保留 1 个快照)
  • 4~7 天内:40 个快照
  • 8~30 天内:115 个快照
  • 31~100 天内:175 个快照
  • ……

按快照具体时间与当前具体时间的差计算,而不是按日期。

分开配置:

  • 云端快照自动清理策略
  • 本地快照自动清理策略

关联需求:

#10787 siyuan-note/dejavu#8

image

@88250
Copy link
Member

88250 commented Nov 16, 2024

云端的不考虑改变策略了,本地的后续考虑看看。

@88250 88250 self-assigned this Nov 16, 2024
@88250
Copy link
Member

88250 commented Nov 16, 2024

考虑了下,清理策略如下:

  • 每天最多保留 x 个快照,默认 2 个(保留每天最后一个,其他随机保留)
  • 保留最近 y 天的快照,默认 180 天
  • 只清理未引用快照,有引用的快照不清理

执行时机:

启动后第一次同步、索引订正结束以后执行,后续每 24 小时执行一次。

@88250 88250 changed the title 快照自动清理策略 Automatic purge for local data repo Nov 16, 2024
@88250 88250 added this to the 3.1.12 milestone Nov 16, 2024
88250 added a commit to siyuan-note/dejavu that referenced this issue Nov 16, 2024
@88250 88250 closed this as completed Nov 16, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 16, 2024

配置界面长啥样?

@88250
Copy link
Member

88250 commented Nov 16, 2024

设置 - 关于

image

等会打个 dev 版

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 16, 2024

这个配置能留空吗?

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 16, 2024

用户更新之后自动清理掉大量快照的话感觉不是很妙,因为用户可能希望保留这些快照

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 16, 2024

还有就是这个配置应该在重启思源之后生效。不然手残输入一个很小的数就麻烦了

@88250
Copy link
Member

88250 commented Nov 16, 2024

就这样吧,清理掉是这个 issue 的目的。

输入后不会清理的,要等重启后同步或者定时任务才执行清理。

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 16, 2024

每天最多保留 x 个快照,默认 2 个(保留每天最后一个,其他随机保留)

这个随机有点怪,为什么不平均分布呢?

@88250
Copy link
Member

88250 commented Nov 16, 2024 via email

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 17, 2024

但是完全随机不是更差吗

@88250
Copy link
Member

88250 commented Nov 17, 2024

随机更好,因为快照本身就无法判断重要性,所以随机反而更平均。

88250 added a commit to siyuan-note/dejavu that referenced this issue Nov 17, 2024
@zxhd863943427
Copy link
Contributor

目前看来这个功能必须有个开关。

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 19, 2024

有个开关的话也需要默认开启,否则用户不会主动开启。

但新增的开关不能默认开启,所以还是不加开关更好。

@zxhd863943427
Copy link
Contributor

但是,在用户设置前,就已经自动执行了

@zxhd863943427
Copy link
Contributor

这导致默认的180天以前的快照会完全丢失

@zxhd863943427
Copy link
Contributor

而且,默认设置的频率也不一定是用户需要的。

@88250
Copy link
Member

88250 commented Nov 19, 2024

这导致默认的180天以前的快照会完全丢失

正在紧急修复,争取等会发版 #13203

@88250
Copy link
Member

88250 commented Nov 19, 2024

新版本已经发布。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants