Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checking for updates on exit #13608

Closed
3 tasks done
flowprog opened this issue Dec 24, 2024 · 9 comments
Closed
3 tasks done

Improve checking for updates on exit #13608

flowprog opened this issue Dec 24, 2024 · 9 comments
Assignees
Milestone

Comments

@flowprog
Copy link

flowprog commented Dec 24, 2024

从托盘退出时如果有新安装包请弹出来而不是卡死在里面也不退出

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

如题,托盘退出时,如果有更新,会卡住,那系统强制关机的时候甚至是否容易造成出错

Expected result

提示更新或直接退出

Screenshot or screen recording presentation

No response

Version environment

- Version: 
- Operating System: win11
- Browser (if used):

Log file

no

More information

No response

@88250 88250 self-assigned this Dec 25, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Dec 25, 2024

@ZSCN2024
Copy link

目前思源的稳定性不太好,小问题也比较多。感觉摊子铺的太大,开发资源跟不上。
用户只能先自适应。比如自动升级的问题,我把自动升级关闭了,每次手动下载安装包升级,这样就不会遇到你说的问题了。

@88250 88250 changed the title 从托盘退出时如果有新安装包请弹出来而不是卡死在里面也不退出 Improve checking for updates on exit Dec 25, 2024
@88250 88250 added this to the 3.1.18 milestone Dec 25, 2024
@88250
Copy link
Member

88250 commented Dec 25, 2024

两个改进:

  1. 有更新可用并且窗口最小化或者隐藏到托盘时弹出主窗口
  2. 退出时不通过网络检查更新,避免网络卡顿

@88250 88250 closed this as completed Dec 25, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Dec 28, 2024

有更新可用并且窗口最小化或者隐藏到托盘时弹出主窗口

感觉不太好,能不能实现重新聚焦窗口的时候才弹出提示?

@88250
Copy link
Member

88250 commented Dec 29, 2024

目的就是要这种情况下弹出哦,否则就会有楼主提到的问题。

@TCOTC
Copy link
Contributor

TCOTC commented Dec 29, 2024

我觉得应该在重新聚焦窗口的时候才弹出提示,用户没打开窗口看到提示都话退出就不更新。

窗口突然打开我觉得不好,用户会反感

@88250
Copy link
Member

88250 commented Dec 29, 2024

只有有更新的时候才弹出,这样也能让用户选择是否更新,直接退出的话就看不到更新提示了。

@TCOTC
Copy link
Contributor

TCOTC commented Dec 29, 2024

下次打开窗口再提示就够了

@88250
Copy link
Member

88250 commented Dec 29, 2024

我觉得目前这样挺好,等看看后面反馈再考虑要不要调整吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants