style: finetuning titlebar look-n-feel for PWA support #13779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous patch (675e59c) introduce initial PWA WCO support, this patch finetunes the PWA titlebar support by ensure the bottom border of the titlebar is always visible and fill 100% page (window) width, with the following changes:
Add extra 1px height to ensure the bottom border won't be covered by the window decoration overlay itself.(Edit: no longer doing this change, see the discussion below)Remaining PWA stuff:
The remaining PWA WCO part have inconsistent color with the actual color that SiYuan('s titlebar) uses, thus to make the PWA titlebar feel native, we still needs to set either:
<meta>
attribute (suggested)...which will be a seprated topic that won't be worked on in this patchset.
Feature or bug? 特性或者缺陷?
不是特性也不算是缺陷,是对 675e59c 的微调来使得 PWA 标题栏具备更好的视觉效果。调整后的视觉效果如下:
相比上一个PR( #13771 )的视觉效果:
此修改旨在使标题栏的底部 border 可以撑满整个窗口,使标题栏的视觉效果看上去更自然。Edit: 此修改目前仅旨在使标题栏盛满整个窗口的宽度,避免 #13226 (comment) 问题。此 PR 不再解决标题栏底部分割线被 WCO 遮挡的问题,原因参见下方的讨论。需要注意,为了满足我自己的视觉效果需求,上面的第一个截图有额外的修改来使 PWA 的窗口装饰背景色和 SiYuan 自身的背景色保持一致。于此相关的变动的概要说明可参见最上面所附的说明(Remaining PWA stuff 部分),此 PR 未包含(也不会包含)关于修改 PWA 主题色的变动。
Multilingual or copywriting? 多语言或者文案?
否。
Dev branch!
已确认目标分支为 dev。