Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support chart #196

Merged
merged 31 commits into from
Oct 10, 2024
Merged

feat: support chart #196

merged 31 commits into from
Oct 10, 2024

Conversation

siyul-park
Copy link
Owner

@siyul-park siyul-park commented Oct 8, 2024

A chart defines a node that combines multiple nodes to perform more complex operations. Charts are used to set up interactions between nodes.

id: 01908c74-8b22-7cbf-a475-6b6bc871b01b
namespace: default
name: sqlite
annotations:
  version: "v1.0.0"
specs:
  - kind: sql
    name: sql
    driver: sqlite3
    source: file::{{ .FILENAME }}:?cache=shared
ports:
  in:
    - name: sql
      port: in      
  out:
    - name: sql
      port: out
env:
  FILENAME:
      value: "{{ .filename }}"
  • id: A unique identifier in UUID format. UUID V7 is recommended.
  • namespace: Specifies the namespace to which the chart belongs, defaulting to default.
  • name: Specifies the name of the chart, which must be unique within the same namespace. This name becomes the type of the node specification.
  • annotations: Additional metadata for the chart, including user-defined key-value pairs such as description and version.
  • specs: Defines the node specifications that make up the chart.
  • ports: Defines how the chart's ports connect. It specifies how external ports should connect to internal nodes.
  • env: Specifies the environment variables required by the chart. If id and name are empty, this is used as an argument for node specifications that utilize this chart.

@siyul-park siyul-park self-assigned this Oct 8, 2024
@siyul-park siyul-park requested a review from ewlkkf October 8, 2024 11:29
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 73.76861% with 229 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (69fb695) to head (8306bd4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
driver/mongo/pkg/chart/store.go 75.62% 25 Missing and 14 partials ⚠️
pkg/chart/chart.go 67.03% 22 Missing and 8 partials ⚠️
cmd/pkg/uniflow/main.go 0.00% 23 Missing ⚠️
pkg/chart/loader.go 64.00% 9 Missing and 9 partials ⚠️
pkg/chart/table.go 88.07% 9 Missing and 9 partials ⚠️
pkg/chart/linker.go 72.13% 11 Missing and 6 partials ⚠️
pkg/runtime/runtime.go 78.37% 8 Missing and 8 partials ⚠️
cmd/pkg/cli/start.go 46.15% 7 Missing and 7 partials ⚠️
pkg/chart/cluster.go 82.43% 10 Missing and 3 partials ⚠️
cmd/pkg/uniflowctl/main.go 0.00% 10 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   76.05%   76.11%   +0.06%     
==========================================
  Files         124      133       +9     
  Lines        7496     8252     +756     
==========================================
+ Hits         5701     6281     +580     
- Misses       1236     1352     +116     
- Partials      559      619      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siyul-park siyul-park merged commit 02b671d into main Oct 10, 2024
4 of 6 checks passed
@siyul-park siyul-park deleted the feature/support_chart branch October 10, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant