Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show detail for failing examples using aggregate_failures #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jasoncodes
Copy link

@jasoncodes jasoncodes commented Oct 18, 2019

Fixes #56

Example

Before

After

Note

There is a minor change to how backtraces are formatted. It’s now the same as what rspec shows when ran from directly:

Before

After

@xuantuan58
Copy link

I am waiting for review and merge from owner

@sj26
Copy link
Owner

sj26 commented Apr 2, 2020

Sorry that this hasn't had attention in a while, @jasoncodes.

I really like this idea, but I'm very concerned that the parsing code seems to be a bit brittle and may break if future rspecs change output formats slightly. I'm not sure what the best answer here, which is why I haven't really jumped into it. 🤔

@jasoncodes
Copy link
Author

What if I made the guards less strict so instead of raising on an unexpected format, they instead silently continue? This should at worst output a bit of duplication instead of erroring.

I’m not sure how to best add coverage for that though. Conditionally stub out fully_formatted_lines so it does something different than expected? Not sure if it’d be worth the effort.

@taylorthurlow
Copy link

@sj26 Sorry to bother, but do you have any further opinion on this?

@taylorthurlow
Copy link

@sj26 Any chance of an update?

@dschweisguth
Copy link

Right now we're running on a fork based on this PR. I too would appreciate any opinions on a way forward. Thanks!

@dimitarizpitaime
Copy link

Any updates on this guys, would really love to see it going in ?

This ensures the Test Summary plugin properly escapes "blank" lines
to avoid breaking out of the Markdown code block.
@krasnoukhov
Copy link

This would be a great addition to merge and then cut a release...

@Drowze
Copy link

Drowze commented Mar 27, 2024

@sj26 any chance we can get this one on a new release? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle multiple failures in aggregate_failures block
8 participants