Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on "View link" popover when it opens to improve keyboard/a11y use #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Focus on "View link" popover when it opens to improve keyboard/a11y use #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/LinkBubbleMenu/ViewLinkMenuContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Button, DialogActions, Link } from "@mui/material";
import { getMarkRange, getMarkType, type Editor } from "@tiptap/core";
import truncate from "lodash/truncate";
import type { ReactNode } from "react";
import { useEffect, useRef, type ReactNode } from "react";
import { makeStyles } from "tss-react/mui";
import useKeyDown from "../hooks/useKeyDown";
import truncateMiddle from "../utils/truncateMiddle";
Expand Down Expand Up @@ -46,6 +46,16 @@ export default function ViewLinkMenuContent({
const currentHref =
(editor.getAttributes("link").href as string | undefined) ?? "";

// Focus on the first interactive element in the popover when it opens, so
// users can use their keyboard to navigate the menu.
// (https://accessibleweb.com/question-answer/where-should-keyboard-focus-go-in-modals/).
// Without this change, the keyboard focus would still be in the editor, which
// means you'd have to use the mouse to interact with the popper menu.
const linkRef = useRef<HTMLAnchorElement | null>(null);
useEffect(() => {
linkRef.current?.focus();
}, []);

// If the user presses escape, we should cancel
useKeyDown("Escape", onCancel);

Expand All @@ -59,7 +69,7 @@ export default function ViewLinkMenuContent({
</div>

<div className={classes.linkPreviewText}>
<Link href={currentHref} target="_blank" rel="noopener">
<Link ref={linkRef} href={currentHref} target="_blank" rel="noopener">
{/* We truncate in the middle, since the beginning and end of a URL are often the most
important parts */}
{truncateMiddle(currentHref, 50)}
Expand Down