Two Add ITA Exam Buttons #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client testing found that if a user had the Office Manager permission set to 1 and wasn't a GA, that two Add ITA Exam buttons would show on the exam invetory page. This issue was fixed by fixing partial logic on the buttons-exams such that a negation is now complete.
sjrumsby
added a commit
that referenced
this pull request
May 24, 2019
* Sprint 11 4 (#261) * Fixed Edit Group Exam Modal to Disable Past Date Selection Exam dates can no longer be edited to a date that is in the past. Also fixed eratic form validation that prevented the submit button from being pressed when certain dates were selected. * Fixed Issue with Appointment Booking Modal Notes Notes were being captured but not displayed in the modal. Fixed. Also adjusted calendar start time to 8:30am. * Fixed Errors in Branch Agenda Previously this component was more complex and it relied on an invisible full-calendar instance to consume and parse the event data however this approach was causing issues. Since the Agenda has recently been simplified and no longer supports multiple views etc., there is no need for full-calendar. Have re-implemented using only moment.js and eliminated the errors related to full-calendar * Deleted Date for Invigilators and Rooms Client was flooded with requests for how to delete invigilators and rooms upon launch. To accomodate for this request but maintain data integrity, a deleted date was added to both the invigilator and room models, such that if these fields were set to a date in the admin panels for these objects, they will no longer show up in the application drop downs or calendars. * Allow Office Mgr to Edit Group/Session Exam Details Logic controlling access to the full version of the Edit Exam Modal did not consider the ita_designate key. Office Manager previously saw only the fields-limited CSR version. Changed so that office mgr has same access as GA role. Also fixed: -liaison_designate were unable to edit office of pesticide exams. -the exam_type field of the EditExamModal was listing exam_types which did not make sense. Disabled the ability to switch exam_type on a pesticide exam or challenger exam at all and restricted changing 'other' 'individual ita' and 'group ita' to exam type options of their catagory only. -adjusted the other field-display and field-disable logic to ensure access to necessary features for office managers -set the time of the editExamSuccess banner to 3 seconds instead of 6 * Admin Panel - Room -> Office Name Sort Clients required rooms to be sorted by office name after testing in production. * Typo (#262) Missing command from sprint-11-4 PR. * Sprint 11 6 (#263) * Admin Panel - Room Searching Client required rooms to be searchable through admin panels. * Backend Changes for Tracking Number Length Bookings application required backend changes to reflect tracking number length of 255 chars. Alembic would not generate a migration file for the length change, so the last migration file in the alembic chain was modified to see this change happen. * Return Exam fix: Action Taken Length & Deleted Invigilator Changes -Action Taken field now displays an error at the maximum input length and prevents further input -Adjusted the exam_inventory table to display the life-ring error symbol on any exam assigned to a deleted invigilator and adjusted the filters to show such exams as not ready. -Changed a call to previous method name which was revised in EditGrouoBooking modal * AddExamForm Modal exam_name length validation Modified existing validation logic to check if exam_name field exceeds 50 characters in length and displays error / prevents advancing until corrected. * Added exam_name length validation to EditExamModal Added validation and an error message as per the Return Exam modal at the 50 character limit. * Fixed Error in Appointments with double clicking Fixed error where double clicking the appointments page would cause two modals to open. Also removed stray console.log from return_exam_modal * Delete Room Admin Warning Clients required there to be a warning given to admin users if a room is about to have a deleted date applied to it, but it currently being used for bookings in the future. The flask admin on_model_change method was used to detect changes in the deleted date field before submission, and looking at the booking model for instances of such a room being used with start times greater than today (doesn't care about historical instances). If the room isn't in use, the room can be deleted. If the room is in use, and error message propagates telling the user that they were unable to apply the deleted date. Any other changes that the user might make on top of applying a deleted date to a room in use will be saved. * Changed displayed hours of Appointments Calendar to 8.30 am - 5 pm (#264) * Sprint 11 2 (#265) * Sprint 11 4 (#261) * Fixed Edit Group Exam Modal to Disable Past Date Selection Exam dates can no longer be edited to a date that is in the past. Also fixed eratic form validation that prevented the submit button from being pressed when certain dates were selected. * Fixed Issue with Appointment Booking Modal Notes Notes were being captured but not displayed in the modal. Fixed. Also adjusted calendar start time to 8:30am. * Fixed Errors in Branch Agenda Previously this component was more complex and it relied on an invisible full-calendar instance to consume and parse the event data however this approach was causing issues. Since the Agenda has recently been simplified and no longer supports multiple views etc., there is no need for full-calendar. Have re-implemented using only moment.js and eliminated the errors related to full-calendar * Deleted Date for Invigilators and Rooms Client was flooded with requests for how to delete invigilators and rooms upon launch. To accomodate for this request but maintain data integrity, a deleted date was added to both the invigilator and room models, such that if these fields were set to a date in the admin panels for these objects, they will no longer show up in the application drop downs or calendars. * Allow Office Mgr to Edit Group/Session Exam Details Logic controlling access to the full version of the Edit Exam Modal did not consider the ita_designate key. Office Manager previously saw only the fields-limited CSR version. Changed so that office mgr has same access as GA role. Also fixed: -liaison_designate were unable to edit office of pesticide exams. -the exam_type field of the EditExamModal was listing exam_types which did not make sense. Disabled the ability to switch exam_type on a pesticide exam or challenger exam at all and restricted changing 'other' 'individual ita' and 'group ita' to exam type options of their catagory only. -adjusted the other field-display and field-disable logic to ensure access to necessary features for office managers -set the time of the editExamSuccess banner to 3 seconds instead of 6 * Admin Panel - Room -> Office Name Sort Clients required rooms to be sorted by office name after testing in production. * Typo (#262) Missing command from sprint-11-4 PR. * Sprint 11 6 (#263) * Admin Panel - Room Searching Client required rooms to be searchable through admin panels. * Backend Changes for Tracking Number Length Bookings application required backend changes to reflect tracking number length of 255 chars. Alembic would not generate a migration file for the length change, so the last migration file in the alembic chain was modified to see this change happen. * Return Exam fix: Action Taken Length & Deleted Invigilator Changes -Action Taken field now displays an error at the maximum input length and prevents further input -Adjusted the exam_inventory table to display the life-ring error symbol on any exam assigned to a deleted invigilator and adjusted the filters to show such exams as not ready. -Changed a call to previous method name which was revised in EditGrouoBooking modal * AddExamForm Modal exam_name length validation Modified existing validation logic to check if exam_name field exceeds 50 characters in length and displays error / prevents advancing until corrected. * Added exam_name length validation to EditExamModal Added validation and an error message as per the Return Exam modal at the 50 character limit. * Fixed Error in Appointments with double clicking Fixed error where double clicking the appointments page would cause two modals to open. Also removed stray console.log from return_exam_modal * Delete Room Admin Warning Clients required there to be a warning given to admin users if a room is about to have a deleted date applied to it, but it currently being used for bookings in the future. The flask admin on_model_change method was used to detect changes in the deleted date field before submission, and looking at the booking model for instances of such a room being used with start times greater than today (doesn't care about historical instances). If the room isn't in use, the room can be deleted. If the room is in use, and error message propagates telling the user that they were unable to apply the deleted date. Any other changes that the user might make on top of applying a deleted date to a room in use will be saved. * Changed displayed hours of Appointments Calendar to 8.30 am - 5 pm (#264) * Update Documentation and OpenShift Templates (#266) * Update Documentation and OpenShift Templates * Service Ctzn Mnmize Button now hides Modal + Allows Navigation Changed the Minimize Button of the Serve Citizen Modal to hide the modal (on the condition that the Service Begun button has been pressed. If citizen is 'invited' only, will revert to previous collapse behaviour). Added conditions to Dash Table, Hold Table, router Navigation Guard for automatic ticket creation in exams, and Dash Buttons, to prevent starting additional tickets with current ticket minimized. Adjusted Simplified Add Service Modal to display the catagories option but default it to 'Exams' instead of hiding it and fixing it on Exams only. Adjusted the Serve Citizen modal to allow creation of ticket from Outside the Q and display message indicating noa active ticket when there is none. * Generate Financial Report - Non Exam Events Client required reporting to be done on Non Exam Events in the booking model as well as Exam events. A separate query was added to the exam_export end point for booking events without exam IDs, and then added another for loop to the query return results parsing, to parse this object and insert rows in the same csv in the form of exam events. Confirmed with the client beforehand what fields should be blank, which fields required hard coded values and what columns were net new (fees collected) * Added Ability to Show Offsite Exams only in Booking Calendar Created a toggle filter as in the Exam Inventory with options: "On-Site", "Offsite", "Both" to replace the current Hide/Show Offsite button. * Added Validation for Required Fields to Return Exam Modal * Added Icon for Returned Exam And updated template slightly to streamline display of Exam Details in Details Row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client testing found that if a user had the Office Manager permission set to 1 and wasn't a GA, that two Add ITA Exam buttons would show on the exam invetory page. This issue was fixed by fixing partial logic on the buttons-exams such that a negation is now complete.