Added components for performing search filtering #76
Conversation
| @@ -38,6 +38,7 @@ class Exam(Base): | |||
| booking = db.relationship("Booking") | |||
| exam_type = db.relationship("ExamType") | |||
| invigilator = db.relationship("Invigilator") | |||
| office = db.relationship("Office") | |||
There was a problem hiding this comment.
I thought we referenced offices from exams through their bookings?
There was a problem hiding this comment.
Exams belong to an office as well. The exams have to, so when they are added by the liason the GA can get a list of the exams in just their office, prior to being booked.
| context.commit('setExams', resp.data.exams) | ||
| }) | ||
| .catch(error => { | ||
| console.log('error @ store.actions.getCsrs') |
There was a problem hiding this comment.
should we be displaying errors in another way? shouldn't errors only be conveyed to users through html responses?
frontend/src/store/index.js
Outdated
| if (index >= 0) { | ||
| state.examFilters.splice(index, 1); | ||
| } else { | ||
| console.log("error finding index for filter in state") |
There was a problem hiding this comment.
should we be displaying errors in another way? shouldn't errors only be conveyed to users through html responses?
There was a problem hiding this comment.
These are mostly just for debugging purposes (same for you other comment). They could probably be removed entirely.
sjrumsby
force-pushed
the
search-filtering
branch
3 times, most recently
from
9962589
to
22e3e3a
Compare
Filtering adds very basic support for kwarg parameter passing from the front end. Can perform search filtering on a limited set of columns, and does not support deep search across relationships or complex search types (e.g., LIKE, OR, GTE, Dates, etc). Does conditionally render the office for LIASON / GA roles in the table.
sjrumsby
force-pushed
the
search-filtering
branch
from
f1d7398
to
f0ceac9
Compare
Filtering adds very basic support for kwarg parameter passing from the front end. Can perform search filtering on a limited set of columns, and does not support deep search across relationships or complex search types (e.g., LIKE, OR, GTE, Dates, etc).
Does conditionally render the office for LIASON / GA roles in the table.