This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Improve emulation of redis -> Lua returns #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some cases omitted from _convert_redis_result e.g. recursively converting lists. A more serious problem is that fakenewsredis follows the types returned by redis-py, which in many cases have a command-specific conversion applied e.g. EXISTS returns bool instead of 0/1. Since in real redis the Lua script is not subject to these conversions, we need to "undo" them. In some cases this can be done generically e.g. bool -> int or float -> str, but in others we need command-specific conversions. This is done with the `@_lua_reply` decorator. There is probably more work needed to handle all the commands: redis-py has a large table of conversions, and I've only handled some of the common cases. Also fixed flushall to return True (independently of Lua).
1 similar comment
This is to match redis's documented behaviour of sorting some arrays when Lua fetches them, to make scripts deterministic.
|
@bmerry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some cases omitted from _convert_redis_result e.g.
recursively converting lists. A more serious problem is that
fakenewsredis follows the types returned by redis-py, which in many
cases have a command-specific conversion applied e.g. EXISTS returns
bool instead of 0/1. Since in real redis the Lua script is not subject
to these conversions, we need to "undo" them.
In some cases this can be done generically e.g. bool -> int or float ->
str, but in others we need command-specific conversions. This is done
with the
@_lua_replydecorator.There is probably more work needed to handle all the commands: redis-py
has a large table of conversions, and I've only handled some of the
common cases.
Also fixed flushall to return True (independently of Lua).