Make gc patch symbols public in 1.9.3-p125 for ruby-prof memory profiles #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix updated line numbers)
|
This patch contains more changes than what you mentioned. Will not apply it. But I will fix the problems you mentioned. |
|
The latest patches address the visibility issue. Please test (I don't have Lion). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby-prof at the moment uses rb_os_allocated_objects, rb_gc_allocated_size, rb_gc_collections and rb_gc_time for it's memory profiles.
But these were exported as private symbols (at least on mac os lion, x64), this patch fixes it.
Also fixed line numbers so no more fuzzy-matching during patch.