Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALE Portal - new Bridge architecture, Vite builder, metaport v2 #111

Merged
merged 47 commits into from
Oct 31, 2023

Conversation

dmytrotkk
Copy link
Contributor

@dmytrotkk dmytrotkk commented Aug 17, 2023

resolves #113, #112, #87, #77, #88

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 11:54am
portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 11:54am

@dmytrotkk dmytrotkk marked this pull request as ready for review October 30, 2023 17:19
@dmytrotkk dmytrotkk requested review from a team, payvint and cstrangedk as code owners October 30, 2023 17:19
@dmytrotkk dmytrotkk requested review from TheGreatAxios and sergiy-skalelabs and removed request for cstrangedk October 30, 2023 17:20
@dmytrotkk dmytrotkk changed the title New Bridge architecture - Vite builder, metaport v2 SKALE Portal - new Bridge architecture, Vite builder, metaport v2 Oct 30, 2023
* @copyright SKALE Labs 2023-Present
*/

import * as React from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to import { useState } from 'react' to take advntage of tree shaking *if applicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dmytrotkk dmytrotkk merged commit a6d2bbc into develop Oct 31, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
@dmytrotkk dmytrotkk deleted the bridge-v2 branch July 25, 2024 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants