Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Create chat definition contract and support multiple outputs #25

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

skarllot
Copy link
Owner

@skarllot skarllot commented Jan 3, 2025

Pull Request

The issue or feature being addressed

  • Need to support a definition of chat script and message parsing

Details on the issue fix or feature implementation

  • Create IChatDefinition contract for configuring chat execution
  • Move message definition to Chats context
  • Rename AllowedModel to LlmModelType and move to Chats context
  • Support multiple outputs

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 81.65680% with 31 lines in your changes missing coverage. Please review.

Project coverage is 39.37%. Comparing base (879d6a2) to head (310bb02).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/Operations/ReviewChanges/ReviewChatDefinition.cs 89.47% 8 Missing ⚠️
...ions/ProxyCompleteChat/ProxyCompleteChatHandler.cs 0.00% 8 Missing ⚠️
...ow/Operations/ProxyCompleteChat/AnthropicMapper.cs 0.00% 7 Missing ⚠️
.../Flow/Operations/ProxyCompleteChat/OpenAiMapper.cs 0.00% 7 Missing ⚠️
src/FlowPair/Chats/Infrastructure/IChatModule.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   39.19%   39.37%   +0.17%     
==========================================
  Files          56       58       +2     
  Lines        1064     1082      +18     
  Branches       91       91              
==========================================
+ Hits          417      426       +9     
- Misses        631      643      +12     
+ Partials       16       13       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skarllot skarllot merged commit 13f575e into main Jan 3, 2025
10 checks passed
@skarllot skarllot deleted the feature/chat-definition branch January 3, 2025 17:40
@skarllot skarllot changed the title feat(chat): Create chat definition contract feat(chat): Create chat definition contract and support multiple outputs Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant