Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Define initial messages on ChatScript #34

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

skarllot
Copy link
Owner

Pull Request

Details on the issue fix or feature implementation

  • Define the initial messages on ChatScript
  • Increment progress using functional style
  • Move business rule for stop keyword creation to ChatThread
  • Fix to handle empty chat workspace correctly

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (0618b9b) to head (3fe7082).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/FlowPair/Chats/Services/ChatService.cs 12.50% 7 Missing ⚠️
src/FlowPair/Chats/Models/ChatScript.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   56.53%   56.53%           
=======================================
  Files          72       72           
  Lines        1562     1569    +7     
  Branches      117      118    +1     
=======================================
+ Hits          883      887    +4     
- Misses        662      666    +4     
+ Partials       17       16    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skarllot skarllot merged commit 4d78535 into main Jan 10, 2025
8 checks passed
@skarllot skarllot deleted the feature/chat-script-initial-messages branch January 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant