Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor chat script #45

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Feature/refactor chat script #45

merged 8 commits into from
Jan 22, 2025

Conversation

skarllot
Copy link
Owner

Pull Request

The issue or feature being addressed

  • Low cohesion between initial messages and chat script

Details on the issue fix or feature implementation

  • Define "chat script" merging original definition and "chat definition"
  • Define initial messages on chat script
  • Refactor existing implementation of chat definition to chat script

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 96.69967% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (5ff6a06) to head (8442929).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rations/CreateUnitTest/CreateUnitTestChatScript.cs 94.36% 2 Missing and 2 partials ⚠️
...Agent/Operations/ReviewChanges/ReviewChatScript.cs 95.31% 2 Missing and 1 partial ⚠️
...rations/UpdateUnitTest/UpdateUnitTestChatScript.cs 94.54% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   56.53%   60.96%   +4.43%     
==========================================
  Files          72       78       +6     
  Lines        1569     1555      -14     
  Branches      118      117       -1     
==========================================
+ Hits          887      948      +61     
+ Misses        666      589      -77     
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skarllot skarllot merged commit 4e11c9e into main Jan 22, 2025
8 checks passed
@skarllot skarllot deleted the feature/refactor-chat-script branch January 22, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant