Fixed leaking classes in autoloader #2000
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2000 +/- ##
========================================
Coverage 0.00% 0.00%
Complexity 391 391
========================================
Files 51 51
Lines 1656 1656
========================================
Misses 1656 1656 |
|
I've done a quick test using the build artefact from "[Fixed leaking classes in autoloader #3654]". I still seem to be getting problems when my plugin and yours are both active. One case was when your code was looking for choose_handler(). I think we are getting a clash over which version of '/guzzlehttp/guzzle/src/functions.php' is loaded - because the identifier is determined from filename, not classname. If I comment out the two guzzle files in arrays in my autoload_static.php and autoload_files,php it seems to work. It may be that the paths I've tested in my code are not using those functions and by commenting them out your code can link the file you want to those identifiers. Would you avoid the problem if you renamed the guzzlehttp directory, e.g. sgdgguzzlehttp before building? You need some way to avoid your file having the same file_identifier as someone else using a different version/namespace. |
|
Hmm, can you please send me your plugin (or some minimal repro) to developer@dedic.eu? I'd like to be able to debug that... |
marekdedic
force-pushed
the
autoload-leak-fix
branch
4 times, most recently
from
2f27fa2
to
675fed4
Compare
marekdedic
force-pushed
the
autoload-leak-fix
branch
from
3a00150
to
6fb5cad
Compare
|
Hi, I pushed some more changes that should fix the e-mailed issue. Also, this PR should fix #2524. @PeterSmith8nss , could you please check them? Thanks! |
|
Just checking are these fixes in 2.13.10 or is there another zip file I
should use to get a build with this in?
…On Mon, 29 Apr 2024 at 13:04, Marek Dědič ***@***.***> wrote:
Hi, I pushed some more changes that should fix the e-mailed issue. Also,
this PR should fix #2524
<#2524>.
@PeterSmith8nss <https://github.com/PeterSmith8nss> , could you please
check them? Thanks!
—
Reply to this email directly, view it on GitHub
<#2000 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3WI6GPALCVQC53RUC7DT7DY7YZMXAVCNFSM6AAAAAAYSR44D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGU2TEMRRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@PeterSmith8nss They aren't in 2.13.10 - use this zip please (may have to rename to |
|
On my development system, I've deleted the existing plugin (to remove my
temporary patches) and installed from your zip file. All seems to be
working fine from the user point of view, but I'm seeing the following PHP
errors in the log:
2024-04-30 14:05:59 [php:error] PHP Fatal error: Allowed memory size of
134217728 bytes exhausted (tried to allocate 98582528 bytes) in
/var/www/html/wp-content/plugins/build-artifact/frontend/class-video-proxy.php
on line 91, referer:
http://localhost:8080/photo-gallery/?sgdg-path-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxOm
Not sure whether this is just a problem with the size of my development
environment/the size of my gallery or something else.
Thanks for all the work on fixing the plugin. Please let me know what
release these patches are destined for as I'm holding at my patched version
until then.
Peter
…On Tue, 30 Apr 2024 at 13:14, Marek Dědič ***@***.***> wrote:
@PeterSmith8nss <https://github.com/PeterSmith8nss> They aren't in
2.13.10 - use this zip please (may have to rename to
skaut-google-drive-gallery.zip):
https://github.com/skaut/skaut-google-drive-gallery/actions/runs/8878119044/artifacts/1456462989
—
Reply to this email directly, view it on GitHub
<#2000 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3WI6GLAW23IJQCIL7VMNZTY76DIXAVCNFSM6AAAAAAYSR44D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVGE3DQMJSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks, what you're seeing is an issue with insufficient PHP memory when serving a video file. By default, PHP only has 128MB, which is low for videos. So you can fix this by making the limit higher, but ideally, we should fix the plugin so that it doesn't eat all the memory... Anyway, that's a separate issue, glad to hear the autoloader works for you, I'll merge this PR and do a new release soon-ish |
|
TODO: The |
marekdedic
force-pushed
the
autoload-leak-fix
branch
from
e8e7f1a
to
6c89cd0
Compare
|
@PeterSmith8nss Version 2.13.11 is out with the fix ;) |
Should close #1992 and possibly closes #1999 - @PeterSmith8nss and @kalich5, could you please check?
Closes #2524 , closes #1165