Smoke теcт на контролы #1885
Merged
Smoke теcт на контролы #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorovlad
force-pushed
the
smoke-tests
branch
19 times, most recently
from
8eb3e67
to
26c4c91
Compare
wKich
reviewed
Feb 14, 2020
wKich
reviewed
Feb 14, 2020
sorovlad
force-pushed
the
smoke-tests
branch
3 times, most recently
from
85df533
to
603f212
Compare
wKich
requested changes
Feb 19, 2020
packages/tests/smokeResources/cra-template-react-ui/template.json
Outdated
Show resolved
Hide resolved
|
Добавь описание в первый комментарий PR, чтобы было сделано и ссылку на связную задачу |
sorovlad
force-pushed
the
smoke-tests
branch
from
603f212
to
9a0e3f9
Compare
Laiff
suggested changes
Feb 19, 2020
packages/react-ui-smoke-test/cra-template-react-ui/package.json
Outdated
Show resolved
Hide resolved
packages/react-ui-smoke-test/cra-template-react-ui/template/src/Components.tsx
Outdated
Show resolved
Hide resolved
wKich
requested changes
Feb 20, 2020
packages/react-ui-smoke-test/cra-template-react-ui/template/src/App.tsx
Outdated
Show resolved
Hide resolved
sorovlad
force-pushed
the
smoke-tests
branch
from
9a0e3f9
to
4c83c75
Compare
wKich
reviewed
Feb 20, 2020
sorovlad
force-pushed
the
smoke-tests
branch
4 times, most recently
from
da2646f
to
52919db
Compare
Laiff
previously approved these changes
Feb 21, 2020
sorovlad
force-pushed
the
smoke-tests
branch
from
52919db
to
bb5aa2c
Compare
wKich
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1773 Добавлен тест, который проверяет что пакет react-ui устанавливается и контролы из него отображаются в браузере без ошибок.
Для сreate-react-app создан шаблон cra-template-react-ui в который добавлены контролы.
Добавлен запуск на teamcity в ReactUI:Lint/Test.
Шаг Lint/Test теперь зависит от Build и берет из него собранный пакет.
Шаги: