Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/show-first-last-buttons-props-pagination #3007

Conversation

phamduylong
Copy link
Contributor

Implment showFirstLastButtons as an option for Pagination componenet. Wrote testcases and fix buttons data-test-id

Linked Issue

Closes #2993

Description

Made showFirstLastButtons a new prop, new testcases for them and adjust data-test-id (assuming they were wrong).

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Implment showFirstLastButtons as an option for Pagination componenet. Wrote testcases and fix buttons data-test-id
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 9d20028

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skeletonlabs/skeleton-svelte Patch
@skeletonlabs/skeleton-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Nov 27, 2024 7:08pm

Copy link

vercel bot commented Nov 27, 2024

@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

@phamduylong
Copy link
Contributor Author

@endigo9740 here's the implementation. Perhaps a bit out of scope but v2 had something like showPreviousNextButtons, do you want me to implement something similar to that? I don't think it's intuitive to have no buttons at all for paginators but that's just my opinion.

Copy link
Contributor

@endigo9740 endigo9740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick change here and then the PR looks good to merge.

Thanks for all the contributions lately. Even the smaller contributions add up and safe us a lot of time! Thanks!

'@skeletonlabs/skeleton-react': patch
---

Show first and last button to be an optional props.
Copy link
Contributor

@endigo9740 endigo9740 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phamduylong two quick things with the changeset:

  1. The description should be prefixed with chore:, bugfix:, etc same as a the branch. I've missed this on your last couple contributions.
  2. The description needs to be a single-line paragraph. As it'll be added as a bullet point list item.

Please refer to any of the generated changelogs to see what I mean.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done that. And no big deal out of my contributions. I'm happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants