-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/show-first-last-buttons-props-pagination #3007
Feat/show-first-last-buttons-props-pagination #3007
Conversation
Implment showFirstLastButtons as an option for Pagination componenet. Wrote testcases and fix buttons data-test-id
🦋 Changeset detectedLatest commit: 9d20028 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
@endigo9740 here's the implementation. Perhaps a bit out of scope but v2 had something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick change here and then the PR looks good to merge.
Thanks for all the contributions lately. Even the smaller contributions add up and safe us a lot of time! Thanks!
.changeset/cuddly-dingos-sell.md
Outdated
'@skeletonlabs/skeleton-react': patch | ||
--- | ||
|
||
Show first and last button to be an optional props. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phamduylong two quick things with the changeset:
- The description should be prefixed with
chore:
,bugfix:
, etc same as a the branch. I've missed this on your last couple contributions. - The description needs to be a single-line paragraph. As it'll be added as a bullet point list item.
Please refer to any of the generated changelogs to see what I mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done that. And no big deal out of my contributions. I'm happy to help.
Implment showFirstLastButtons as an option for Pagination componenet. Wrote testcases and fix buttons data-test-id
Linked Issue
Closes #2993
Description
Made showFirstLastButtons a new prop, new testcases for them and adjust data-test-id (assuming they were wrong).
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test