Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT disable combobox multiple prop #3033

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Dec 9, 2024

Linked Issue

Closes #2963

Description

Disables the Zag-based multiple prop for the Svelte Combobox, as this is an unsupported feature.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: a4aab96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Dec 9, 2024 7:50pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
skeleton-next ⬜️ Ignored (Inspect) Dec 9, 2024 7:50pm
skeleton-themes ⬜️ Ignored (Inspect) Dec 9, 2024 7:50pm

@endigo9740 endigo9740 merged commit e512faf into next Dec 9, 2024
7 of 8 checks passed
@magiceupho
Copy link

Hi,
Do you have an advice on how to implement a combobox with multiple values please ?

@endigo9740
Copy link
Contributor Author

@magiceupho from the description above:

Disables the Zag-based multiple prop for the Svelte Combobox, as this is an unsupported feature.

In short, you don't. We may revisit support for this in the future, but right now it's not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants