Version 0.2.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L_SECRET_ID' was not found
calebkleveter
added
bug
This let you access the secret and ID anyway you want and pass them into the PayPalProvider initializer instead of having to assign environment variables
Replaced version initialization in PayPalProvider with a Version enum, making all versions safe. You can't pass in a bad number, i.e. 3.1415
calebkleveter
added
the
Don't Merge
Added required .version property to all PayPalController types. Reaplced throwing .path() method with .path computed property
…ved /PaymentDetails dir to /Payment/Details dir
calebkleveter
force-pushed
the
develop
branch
2 times, most recently
from
b28a0bf to
2e48999
Compare
Instead of having a protocol that two separate types conform to, we use a base generic type that can use different coding keys for encoding/decoding the currency and value We also changed the type from String to Decimal. This removes the need to validation of the property and feels more native. The custom encoding/decoding methods use string<->decimal conversion for the value
calebkleveter
force-pushed
the
develop
branch
from
2e48999 to
1e288ef
Compare
…d of String for money amounts
…vices/states _with_ codes. Wrote test suite for enum
calebkleveter
removed
the
Don't Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Fixes #3