-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow more flexibility for use as a library #613
Conversation
288e8e7
to
91028f3
Compare
7232083
to
7424baf
Compare
I know where the selector issue is coming from, I should be able to fix it today. Just a dumb mistake on my part |
I need to add a few examples too, to showcase this and serve as basic non-regression checks |
@idanarye can you check the selector now ? |
@LoricAndre Can confirm that |
If I can bother you some more, @idanarye could you take a quick look at the examples to make sure they reproduce (very basically) your use case ? |
@LoricAndre The examples seem adequate. |
@idanarye it's merged, so you should be able to use it from now on ! Please tell us about any issue you might face in the future, projects like yours are a great way to showcase's and progressively improve skim library features. |
Thanks! I've made a release for my plugin that migrates back to Skim. |
And... I had to yank it because of a bug. But that's on me (I think I know what it is) and I'll fix it later. EDIT: okay, this is weird - I cannot reproduce this bug. I think maybe it was just my upgrade going wrong? Anyway, I'm unyanked the version... |
cmd_collector
to optionsselector
to optionsRankCriteria
public at crate root