Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow more flexibility for use as a library #613

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

LoricAndre
Copy link
Contributor

@LoricAndre LoricAndre commented Nov 24, 2024

  • Readd cmd_collector to options
  • Readd selector to options
  • Make RankCriteria public at crate root

@LoricAndre LoricAndre linked an issue Nov 24, 2024 that may be closed by this pull request
@LoricAndre LoricAndre force-pushed the fix/cmd-collector-in-options branch from 288e8e7 to 91028f3 Compare November 24, 2024 17:55
@LoricAndre LoricAndre changed the title fix: revert options and context split fix: revert splitting options and context & make options module public Nov 24, 2024
@LoricAndre LoricAndre changed the title fix: revert splitting options and context & make options module public feat: allow more flexibility for use in libraries Nov 24, 2024
@LoricAndre LoricAndre changed the title feat: allow more flexibility for use in libraries feat: allow more flexibility for use as a library Nov 24, 2024
@LoricAndre LoricAndre force-pushed the fix/cmd-collector-in-options branch from 7232083 to 7424baf Compare November 24, 2024 23:29
@LoricAndre LoricAndre modified the milestones: v0.14.0, v0.13.0 Nov 24, 2024
@LoricAndre LoricAndre self-assigned this Nov 24, 2024
@LoricAndre LoricAndre added the lib label Nov 24, 2024
@LoricAndre
Copy link
Contributor Author

I know where the selector issue is coming from, I should be able to fix it today. Just a dumb mistake on my part

@LoricAndre
Copy link
Contributor Author

I need to add a few examples too, to showcase this and serve as basic non-regression checks

@LoricAndre
Copy link
Contributor Author

@idanarye can you check the selector now ?

@idanarye
Copy link

@LoricAndre Can confirm that selector works now. Thanks!

@LoricAndre
Copy link
Contributor Author

If I can bother you some more, @idanarye could you take a quick look at the examples to make sure they reproduce (very basically) your use case ?

@idanarye
Copy link

@LoricAndre The examples seem adequate.

@LoricAndre LoricAndre merged commit 33ca402 into master Nov 25, 2024
5 checks passed
@LoricAndre LoricAndre deleted the fix/cmd-collector-in-options branch November 25, 2024 15:54
@LoricAndre
Copy link
Contributor Author

@idanarye it's merged, so you should be able to use it from now on ! Please tell us about any issue you might face in the future, projects like yours are a great way to showcase's and progressively improve skim library features.

@idanarye
Copy link

Thanks! I've made a release for my plugin that migrates back to Skim.

@idanarye
Copy link

idanarye commented Nov 25, 2024

And... I had to yank it because of a bug. But that's on me (I think I know what it is) and I'll fix it later.

EDIT: okay, this is weird - I cannot reproduce this bug. I think maybe it was just my upgrade going wrong? Anyway, I'm unyanked the version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a way to set the CommandCollector
2 participants