Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add check forex markets to constants for checking #743

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 13, 2024

No description provided.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. do we want to be able to enable these with PR labels?

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (b59c76f) to head (568ab3c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scripts/genesis.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   57.03%   57.00%   -0.03%     
==========================================
  Files         208      208              
  Lines       11632    11636       +4     
==========================================
- Hits         6634     6633       -1     
- Misses       4395     4400       +5     
  Partials      603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aljo242 aljo242 requested a review from zrbecker as a code owner September 18, 2024 19:14
@aljo242 aljo242 merged commit b3832ae into main Sep 19, 2024
15 of 17 checks passed
@aljo242 aljo242 deleted the feat/forex-check branch September 19, 2024 13:41
aljo242 added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants