Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a communityposts collection, and set up a basic sample post on said page #25

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

JonathanPartain
Copy link
Collaborator

Start of the solution for issue #24
Could not use just "posts" - or at least had difficulties doing it as it is a "reserved" word in a sense, there are existing posts layouts etc. Feel free to come with ideas to improve or changes

In order for pagination to work, index file has to be .html, so some minor changes have been made there as well.

This is to ensure consistency among the pages. Furthermore, the `.html`
extension is omitted in the build process, so the `permalink` is
necessary to ensure that the links work as expected.
Gemfile Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@michalspano
Copy link
Contributor

Good job, @JonathanPartain! I understand and I see that posts is a reserved keyword. I suppose 'Community Posts' works well, but it may be a bit too long. I'll see what other sensible alternatives there are.

@michalspano michalspano added this to the v0.0.0 milestone Nov 17, 2023
@JonathanPartain
Copy link
Collaborator Author

@michalspano One alternative is to use the communityposts as the collection, but instead set the title, path and so forth to just "posts"

@michalspano
Copy link
Contributor

@michalspano One alternative is to use the communityposts as the collection, but instead set the title, path and so forth to just "posts"

Yup, that I believe sounds like a good idea.

…. changed community posts to be just 'posts', and modified the permalinks
@JonathanPartain
Copy link
Collaborator Author

@michalspano One alternative is to use the communityposts as the collection, but instead set the title, path and so forth to just "posts"

Yup, that I believe sounds like a good idea.

Done

Copy link
Contributor

@michalspano michalspano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thanks for the help; approved!

@JonathanPartain JonathanPartain merged commit dff5066 into main Nov 17, 2023
@michalspano michalspano deleted the community-posts-page branch November 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants