Sync

.eslintrc.js

@@ -59,6 +59,6 @@ module.exports = {
   },
 
   globals: {
-    expectDev: true,
+    spyOnDev: true,
   },
 };

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,9 +4,10 @@
 2. Run `yarn` in the repository root.
 3. If you've fixed a bug or added code that should be tested, add tests!
 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
-5. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
-6. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
-7. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
-8. If you haven't already, complete the CLA.
+5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
+6. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
+7. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
+8. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
+9. If you haven't already, complete the CLA.
 
 **Learn more about contributing:** https://reactjs.org/docs/how-to-contribute.html

.gitignore

@@ -20,4 +20,4 @@ chrome-user-data
 *.iml
 .vscode
 *.swp
-*.swo
+*.swo

fixtures/dom/src/components/fixtures/input-change-events/RadioNameChangeFixture.js

@@ -0,0 +1,48 @@
+const React = window.React;
+const noop = n => n;
+
+class RadioNameChangeFixture extends React.Component {
+  state = {
+    updated: false,
+  };
+  onClick = () => {
+    this.setState(state => {
+      return {updated: !state.updated};
+    });
+  };
+  render() {
+    const {updated} = this.state;
+    const radioName = updated ? 'firstName' : 'secondName';
+    return (
+      <div>
+        <label>
+          <input
+            type="radio"
+            name={radioName}
+            onChange={noop}
+            checked={updated === true}
+          />
+          First Radio
+        </label>
+
+        <label>
+          <input
+            type="radio"
+            name={radioName}
+            onChange={noop}
+            checked={updated === false}
+          />
+          Second Radio
+        </label>
+
+        <div>
+          <button type="button" onClick={this.onClick}>
+            Toggle
+          </button>
+        </div>
+      </div>
+    );
+  }
+}
+
+export default RadioNameChangeFixture;

fixtures/dom/src/components/fixtures/input-change-events/index.js

@@ -3,6 +3,7 @@ import TestCase from '../../TestCase';
 import RangeKeyboardFixture from './RangeKeyboardFixture';
 import RadioClickFixture from './RadioClickFixture';
 import RadioGroupFixture from './RadioGroupFixture';
+import RadioNameChangeFixture from './RadioNameChangeFixture';
 import InputPlaceholderFixture from './InputPlaceholderFixture';
 const React = window.React;
 
@@ -88,6 +89,25 @@ class InputChangeEvents extends React.Component {
 
           <InputPlaceholderFixture />
         </TestCase>
+        <TestCase
+          title="Radio button groups with name changes"
+          description={`
+            A radio button group should have correct checked value when
+            the names changes
+          `}
+          resolvedBy="#11227"
+          affectedBrowsers="IE9+">
+          <TestCase.Steps>
+            <li>Click the toggle button</li>
+          </TestCase.Steps>
+
+          <TestCase.ExpectedResult>
+            The checked radio button should switch between the first and second
+            radio button
+          </TestCase.ExpectedResult>
+
+          <RadioNameChangeFixture />
+        </TestCase>
       </FixtureSet>
     );
   }

package.json

@@ -8,6 +8,7 @@
     "art": "^0.10.1",
     "async": "^1.5.0",
     "babel-cli": "^6.6.5",
+    "babel-code-frame": "^6.26.0",
     "babel-core": "^6.0.0",
     "babel-eslint": "^7.1.0",
     "babel-jest": "^21.3.0-beta.4",
@@ -34,6 +35,7 @@
     "babel-plugin-transform-es3-property-literals": "^6.5.0",
     "babel-plugin-transform-object-rest-spread": "^6.6.5",
     "babel-plugin-transform-react-jsx-source": "^6.8.0",
+    "babel-plugin-transform-regenerator": "^6.26.0",
     "babel-preset-react": "^6.5.0",
     "babel-traverse": "^6.9.0",
     "babylon": "6.15.0",
@@ -44,6 +46,7 @@
     "core-js": "^2.2.1",
     "coveralls": "^2.11.6",
     "create-react-class": "^15.6.2",
+    "cross-env": "^5.1.1",
     "del": "^2.0.2",
     "derequire": "^2.0.3",
     "escape-string-regexp": "^1.0.5",
@@ -76,7 +79,7 @@
     "prettier": "1.8.1",
     "prop-types": "^15.6.0",
     "rimraf": "^2.6.1",
-    "rollup": "^0.49.3",
+    "rollup": "^0.51.7",
     "rollup-plugin-alias": "^1.2.1",
     "rollup-plugin-babel": "^2.7.1",
     "rollup-plugin-closure-compiler-js": "^1.0.4",
@@ -101,40 +104,14 @@
     "linc": "node ./scripts/tasks/linc.js",
     "lint": "node ./scripts/tasks/eslint.js",
     "postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json",
-    "test": "jest",
+    "test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js",
+    "test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js",
+    "test-prod-build": "yarn test-build-prod",
+    "test-build": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.build.js",
+    "test-build-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.build.js",
     "flow": "node ./scripts/tasks/flow.js",
     "prettier": "node ./scripts/prettier/index.js write-changed",
     "prettier-all": "node ./scripts/prettier/index.js write",
     "version-check": "node ./scripts/tasks/version-check.js"
-  },
-  "jest": {
-    "modulePathIgnorePatterns": [
-      "<rootDir>/scripts/rollup/shims/",
-      "<rootDir>/scripts/bench/"
-    ],
-    "transform": {
-      ".*": "./scripts/jest/preprocessor.js"
-    },
-    "setupFiles": [
-      "./scripts/jest/setup.js",
-      "./scripts/jest/environment.js"
-    ],
-    "setupTestFrameworkScriptFile": "./scripts/jest/test-framework-setup.js",
-    "testRegex": "/__tests__/.*(\\.js|\\.coffee|[^d]\\.ts)$",
-    "moduleFileExtensions": [
-      "js",
-      "json",
-      "node",
-      "coffee",
-      "ts"
-    ],
-    "roots": [
-      "<rootDir>/packages",
-      "<rootDir>/scripts"
-    ],
-    "collectCoverageFrom": [
-      "packages/**/*.js"
-    ],
-    "timers": "fake"
   }
 }

packages/events/__tests__/EventPluginRegistry-test.js → packages/events/__tests__/EventPluginRegistry-test.internal.js

@@ -15,7 +15,10 @@ describe('EventPluginRegistry', () => {
 
   beforeEach(() => {
     jest.resetModuleRegistry();
-    // TODO: can we express this test with only public API?
+    // These tests are intentionally testing the private injection interface.
+    // The public API surface of this is covered by other tests so
+    // if `EventPluginRegistry` is ever deleted, these tests should be
+    // safe to remove too.
     EventPluginRegistry = require('events/EventPluginRegistry');
 
     createPlugin = function(properties) {

packages/react-call-return/src/ReactCallReturn.js

@@ -7,19 +7,9 @@
  * @flow
  */
 
-import type {ReactCall, ReactNodeList, ReactReturn} from 'shared/ReactTypes';
+import {REACT_CALL_TYPE, REACT_RETURN_TYPE} from 'shared/ReactSymbols';
 
-// The Symbol used to tag the special React types. If there is no native Symbol
-// nor polyfill, then a plain number is used for performance.
-var REACT_CALL_TYPE;
-var REACT_RETURN_TYPE;
-if (typeof Symbol === 'function' && Symbol.for) {
-  REACT_CALL_TYPE = Symbol.for('react.call');
-  REACT_RETURN_TYPE = Symbol.for('react.return');
-} else {
-  REACT_CALL_TYPE = 0xeac8;
-  REACT_RETURN_TYPE = 0xeac9;
-}
+import type {ReactCall, ReactNodeList, ReactReturn} from 'shared/ReactTypes';
 
 type CallHandler<T> = (props: T, returns: Array<mixed>) => ReactNodeList;
 

packages/react-cs-renderer/src/ReactNativeCSFeatureFlags.js

@@ -12,6 +12,7 @@ import invariant from 'fbjs/lib/invariant';
 import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
 import typeof * as CSFeatureFlagsType from './ReactNativeCSFeatureFlags';
 
+export const debugRenderPhaseSideEffects = false;
 export const enableAsyncSubtreeAPI = true;
 export const enableAsyncSchedulingByDefaultInReactDOM = false;
 export const enableReactFragment = false;