-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOBPlugin: Implementation and tests #206
Conversation
@vivitsa-s didn't the |
@prashantskit can you review the logic, and test cases? |
@vivitsa-s type checks are failing for the dob plugin |
b7004ae
to
c9a82c8
Compare
@prashantskit @vivitsa-s unit tests for the DOB plugin are failing. from what i can see, this is because of two things:
Can we address these two things? Specifically for 2, can we have unit tests that are not dependent on the internal logic of the plugin? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
- Coverage 88.95% 88.90% -0.05%
==========================================
Files 61 62 +1
Lines 3059 3190 +131
==========================================
+ Hits 2721 2836 +115
- Misses 338 354 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…pt if match not found
…_transcripts_from_utterances function to handle annotation type fail
…_transcripts_from_utterances
… attain full coverage
For more details on 1 and 2, please see: https://www.notion.so/Parser-Wrapper-to-fix-format-issues-00cdba3e731348bd9a9b7b0fd079864a