Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOBPlugin: Implementation and tests #206

Merged
merged 26 commits into from
Jan 10, 2024
Merged

DOBPlugin: Implementation and tests #206

merged 26 commits into from
Jan 10, 2024

Conversation

vivitsa-s
Copy link
Contributor

  1. dialogy/plugins/text/dob_plugin: added plugin
  2. tests/plugin/text/test_dob_plugin: added tests and test cases- (data from 27 turns corresponding to 17 calls)
  3. pyproject.toml: added the library "word2number"

For more details on 1 and 2, please see: https://www.notion.so/Parser-Wrapper-to-fix-format-issues-00cdba3e731348bd9a9b7b0fd079864a

@janaab11 janaab11 changed the title Dob feat: DOB plugin Jan 3, 2024
@janaab11 janaab11 assigned vivitsa-s and unassigned janaab11 Jan 3, 2024
@janaab11
Copy link
Contributor

janaab11 commented Jan 3, 2024

@vivitsa-s didn't the poetry.lock file also change when adding a new package?

@janaab11
Copy link
Contributor

janaab11 commented Jan 3, 2024

@prashantskit can you review the logic, and test cases?

@janaab11
Copy link
Contributor

janaab11 commented Jan 3, 2024

@vivitsa-s type checks are failing for the dob plugin

@janaab11 janaab11 marked this pull request as draft January 4, 2024 09:04
@janaab11
Copy link
Contributor

janaab11 commented Jan 4, 2024

@prashantskit @vivitsa-s unit tests for the DOB plugin are failing. from what i can see, this is because of two things:

  1. Duckling responses are not mocked
  2. an aggregate metric (~correctness) is used instead of independent assertions

Can we address these two things? Specifically for 2, can we have unit tests that are not dependent on the internal logic of the plugin? Correctness seems like a development metric which should live elsewhere

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a651397) 88.95% compared to head (0560548) 88.90%.

Files Patch % Lines
dialogy/plugins/text/dob_plugin/__init__.py 87.50% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   88.95%   88.90%   -0.05%     
==========================================
  Files          61       62       +1     
  Lines        3059     3190     +131     
==========================================
+ Hits         2721     2836     +115     
- Misses        338      354      +16     
Flag Coverage Δ
unittests 88.90% <87.59%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janaab11 janaab11 removed the request for review from prashantskit January 9, 2024 11:10
@janaab11 janaab11 marked this pull request as ready for review January 9, 2024 11:12
@janaab11 janaab11 changed the title feat: DOB plugin DOBPlugin: Implementation and tests Jan 10, 2024
@janaab11 janaab11 merged commit e5b8e34 into master Jan 10, 2024
3 checks passed
@janaab11 janaab11 deleted the dob branch January 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants