Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when opening character after adding attributes and sections #46

Open
skjiisa opened this issue Jan 24, 2020 · 1 comment
Open

Crash when opening character after adding attributes and sections #46

skjiisa opened this issue Jan 24, 2020 · 1 comment
Labels
bug Something isn't working question Further information is requested SwiftUI A SwiftUI conversion would render this obsolete

Comments

@skjiisa
Copy link
Owner

skjiisa commented Jan 24, 2020

Actions performed:

  • Opened character with no Attributes
  • Added two attribute sections
  • Added one different attribute to each section
  • Save character
  • Tap on character again from character list

This caused the app to crash on the titleForHeaderInSection function in CharacterDetailTableViewController with an index out of range. It was trying to load section index 2 but the only value in allSections was the "Character" section. This occurred in commit eb5df1e. It has not been able to be reproduced.
@skjiisa skjiisa added bug Something isn't working question Further information is requested labels Jan 24, 2020
@skjiisa skjiisa changed the title Crash when opening character after adding Crash when opening character after adding attributes and sections Jan 24, 2020
@skjiisa
Copy link
Owner Author

skjiisa commented Feb 4, 2020

Had this happen again after removing a section from a character and saving.

skjiisa added a commit that referenced this issue Feb 4, 2020
@skjiisa
Prevent crash on unexpected behavior with section count
8b6bb31 
Addresses #46 by preventing crash, but doesn't fix whatever is causing the issue in the first place
@skjiisa skjiisa added the SwiftUI A SwiftUI conversion would render this obsolete label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested SwiftUI A SwiftUI conversion would render this obsolete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skjiisa