Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug : packager generates a solution which goes outside the bounds of the container. #453

Closed
tyrcho opened this issue Feb 25, 2022 · 4 comments

Comments

@tyrcho
Copy link
Collaborator

tyrcho commented Feb 25, 2022

as shown in https://github.com/skjolber/3d-bin-container-packing/pull/452/files the packager sometimes generates a solution which goes outside the bounds of the container.

I've provided a new test method to help check the results.

Note : it would be quite helpful to provide a method which generates this "packaging" as a property of the result container !

packaging [26, 62, 63] ([2[0x0x0 31x26x20], 1[32x0x0 63x23x18], 3[0x0x21 33x23x41], 4[34x0x21 63x22x39], 5[0x0x42 29x24x62]])
 should fit into container [44, 56, 70]
@skjolber
Copy link
Owner

@tyrcho thanks for the bug report, I'll release a fix tomorrow.

@skjolber
Copy link
Owner

Note : it would be quite helpful to provide a method which generates this "packaging" as a property of the result container !

tyrcho Can you elaborate on this?

skjolber added a commit that referenced this issue Feb 26, 2022
* Fix height problem with fast LAFF
* Add assertions + pass stack instead of container in some packagers

Co-authored-by: Michel Daviot <michel.daviot@colisweb.com>
@tyrcho
Copy link
Collaborator Author

tyrcho commented Feb 26, 2022 via email

@skjolber
Copy link
Owner

Fixed in latest release. Added "occupied space" as #457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants