-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe): create course detail home #2351
base: main
Are you sure you want to change the base?
Conversation
The preview deployment is in progress. 🟡 Last updated at: 2025-02-14 11:17:26 CET |
apps/frontend/app/(client)/(main)/course/[courseId]/_components/CourseInfoBox.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/CourseInfoBox.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/OngoingAssignments.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/CourseInfoBox.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/RecentNotice.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/Sidebar.tsx
Outdated
Show resolved
Hide resolved
…s/RecentNotice.tsx Co-authored-by: Kwon Seo Jin <97675977+B0XERCAT@users.noreply.github.com>
apps/frontend/app/(client)/(main)/course/[courseId]/_components/OngoingAssignments.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/RecentNotice.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/app/(client)/(main)/course/[courseId]/_components/RecentUpdate.tsx
Outdated
Show resolved
Hide resolved
코드리뷰 화면으로 가보시면 안 쓰는 것들 정리해주세요! |
apps/frontend/app/(client)/(main)/course/[courseId]/_components/CourseInfoBox.tsx
Outdated
Show resolved
Hide resolved
<div className="flex flex-col"> | ||
<Image src={codedangBannerMiddle} alt="코드당" width={70} /> | ||
<div className="flex-col text-center"> | ||
<h2 className="py-5 font-mono text-4xl font-bold text-white md:text-[56px]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
글씨체 수정 필요해보입니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
course main page 커버에아이콘 배치가 피그마랑 조금 다른 것 같아요
아 배너디자인은 잠시 멈췄다고 description에 써져있군요! |
Description
Course Detail - Home 페이지의 디자인을 적용했습니다. (1번째 screenshot)
Banner와 Reminder의 디자인은 아직 미완성인 것 같아서 개발을 멈췄습니다. (2,3 번째 screenshot)
문제:
RecentUpdate.tsx에서 하단의 코드가 의도하는 것처럼 동작하지 않는데, 혹시 해결방법을 알고 계시면 조언 부탁드립니다.
(SVG파일의 색 변경하기)
<svg
width="20"
height="20"
className="mb-1 mr-2 inline-block"
fill={update.isNew ? '#ffffff' : '#8A8A8A'}
Additional context
Before submitting the PR, please make sure you do the following
fixes #123
).closes TAS-1234