Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): create course detail home #2351

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

mingyu27
Copy link
Contributor

@mingyu27 mingyu27 commented Feb 3, 2025

Description

Course Detail - Home 페이지의 디자인을 적용했습니다. (1번째 screenshot)
Banner와 Reminder의 디자인은 아직 미완성인 것 같아서 개발을 멈췄습니다. (2,3 번째 screenshot)

문제:
RecentUpdate.tsx에서 하단의 코드가 의도하는 것처럼 동작하지 않는데, 혹시 해결방법을 알고 계시면 조언 부탁드립니다.
(SVG파일의 색 변경하기)
<svg
width="20"
height="20"
className="mb-1 mr-2 inline-block"
fill={update.isNew ? '#ffffff' : '#8A8A8A'}

Additional context

image image image

Before submitting the PR, please make sure you do the following

closes TAS-1234

@coolify-skkuding
Copy link

coolify-skkuding bot commented Feb 3, 2025

The preview deployment is in progress. 🟡

Open Build Logs

Last updated at: 2025-02-14 11:17:26 CET

@mingyu27 mingyu27 changed the title T1234 course detail home feat(fe): create course detail home Feb 3, 2025
Copy link

mingyu27 and others added 3 commits February 3, 2025 23:40
…s/RecentNotice.tsx

Co-authored-by: Kwon Seo Jin <97675977+B0XERCAT@users.noreply.github.com>
@mingyu27 mingyu27 requested a review from B0XERCAT February 5, 2025 10:49
@B0XERCAT
Copy link
Member

B0XERCAT commented Feb 5, 2025

코드리뷰 화면으로 가보시면
GitHub Actions / Lint
OOO is defined but never used
같은 게 많이 떠 있는데

안 쓰는 것들 정리해주세요!

@mingyu27 mingyu27 requested review from juhyeong0505 and removed request for jwoojin9 February 5, 2025 11:22
@B0XERCAT B0XERCAT requested review from jihorobert and removed request for juhyeong0505 February 10, 2025 12:24
<div className="flex flex-col">
<Image src={codedangBannerMiddle} alt="코드당" width={70} />
<div className="flex-col text-center">
<h2 className="py-5 font-mono text-4xl font-bold text-white md:text-[56px]">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

글씨체 수정 필요해보입니다!

Copy link
Contributor

@jihorobert jihorobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

course main page 커버에아이콘 배치가 피그마랑 조금 다른 것 같아요

@jihorobert
Copy link
Contributor

jihorobert commented Feb 11, 2025

아 배너디자인은 잠시 멈췄다고 description에 써져있군요!
피그마에 반응형 디자인은 현재 없는 것 같기는 한데, 디자인 팀이 바쁜 것 같으니 우선 프론트쪽에서 알아서 적당히 볼 수 있게끔 만들어 놓으면 될 것 같아요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress 🏃
Development

Successfully merging this pull request may close these issues.

4 participants