Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KubeResourceManager api for kubernetes clients #214

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

kornys
Copy link
Member

@kornys kornys commented Jan 22, 2025

Description

  1. Remove static ability to get clients because clients are not initialized without singleton is initialized first so it is save to get it from instance.
  2. remove the get.. prefix from kubeClient() and kubeCmdClient()

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys added this to the 0.10.0 milestone Jan 22, 2025
@kornys kornys self-assigned this Jan 22, 2025
@kornys kornys changed the title Update KubeResourceManager api for f8 clients Update KubeResourceManager api for kubernetes clients Jan 22, 2025
@github-actions github-actions bot requested review from Frawless and im-konge January 22, 2025 09:48
@kornys kornys merged commit 9a6c828 into main Jan 22, 2025
7 checks passed
@kornys kornys deleted the krm-api-v1beta2 branch January 22, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants