Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 publish blog #6

Merged
merged 5 commits into from
Sep 10, 2021
Merged

3 publish blog #6

merged 5 commits into from
Sep 10, 2021

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Sep 3, 2021

Publish under root level.

See #3.

dr0i added 3 commits September 2, 2021 17:36
Don't build links with "skohub-blog" prefix as these would result in adding
that path to our publish site. As we use a subdomain "blog.skohub.io" we don't
want to need this.
@dr0i dr0i requested a review from katauber September 3, 2021 06:45
README.md Show resolved Hide resolved
@dr0i
Copy link
Member Author

dr0i commented Sep 3, 2021

@katauber see my own code comment where I asked about advice and: the package-lock.json is now huge (~2 MB) - is this ok?

@katauber
Copy link
Member

katauber commented Sep 3, 2021

@katauber see my own code comment where I asked about advice and: the package-lock.json is now huge (~2 MB) - is this ok?

I think the size itself is no problem but what I don't understand why it is so much bigger than before (from ~ 21000 lines to 46000 lines). Maybe the reason is that I use lockfile version 1 (npm v6) and you used lockfile version 2 (npm v7), see https://stackoverflow.com/questions/11414392/git-diff-thinks-the-last-line-of-the-file-has-been-moved-after-the-end-of-file. If that is the reason I think it's ok. I will update my npm version to v7 and see what happens with the package-lock.json.

@dr0i
Copy link
Member Author

dr0i commented Sep 3, 2021

The cause of the huge package-json.lock seems indeed because of lockfile version 2.

@katauber
Copy link
Member

katauber commented Sep 7, 2021

Sorry, I wanted to link this url https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion in my last comment. That makes more sense.

The cause of the huge package-json.lock seems indeed because of lockfile version 2.

👍

Copy link
Member

@katauber katauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the different npm versions result in different package-lock.json files, there should a recommendation of npm version (7?) in the README.

@fsteeg fsteeg linked an issue Sep 7, 2021 that may be closed by this pull request
@katauber katauber assigned dr0i and unassigned katauber Sep 7, 2021
This config file of format rules can be applied by many IDEs and editors,
e.g. codium and vim. Some need an extra plugin for that, like the latter.
@dr0i
Copy link
Member Author

dr0i commented Sep 10, 2021

there should a recommendation of npm version (7?) in the README.

There is already a note in the README ( nvm use 15 ), I think that make me build it using lockfile version 2. So we can leave it as it is.

@dr0i dr0i requested a review from katauber September 10, 2021 08:29
@dr0i dr0i assigned katauber and unassigned dr0i Sep 10, 2021
@katauber katauber assigned dr0i and unassigned katauber Sep 10, 2021
@dr0i dr0i merged commit 284aa27 into main Sep 10, 2021
@dr0i dr0i deleted the 3-publishBlog branch September 10, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Publish blog with GitHub pages
2 participants