Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom domain #271 #272

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add support for custom domain #271 #272

merged 3 commits into from
Oct 24, 2023

Conversation

sroertgen
Copy link
Contributor

This PR adds support for custom domains as requested by @carlschuurbiers

@carlschuurbiers Would you mind testing this branch out to see if it fits your needs?

I added documentation about how to use the custom domain.

You just have to add custom_domain: "http://your-domain.org" to your config.yaml

@sroertgen sroertgen self-assigned this Sep 29, 2023
@sroertgen sroertgen linked an issue Sep 29, 2023 that may be closed by this pull request
Copy link

@carlschuurbiers carlschuurbiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for my case, only the custom logo is somehow broken, not sure what caused this, maybe it is not related, will need to check this.

Hat bei mir funktioniert, nur mein "custom logo" ist kaputt, bin mir nicht sicher was genau die Ursache ist, kann auch an was anderes gelegen haben, prüfe ich noch.

Copy link

@carlschuurbiers carlschuurbiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention: the custom domain must be a https:// because http:// doesn't work. For me not a problem because nowadays all sites are secure https:// or should be. Maybe consider adding an error message?

Achtung: der Custom Domain muss als https:// definiert sein, http:// funktioniert nicht. Sehe ich aber nicht als Problem da eigentlich alle Domains heutzutage https sein oder es sein sollten. Vielleicht Fehlermeldung einbauen?

@sroertgen
Copy link
Contributor Author

Hey @carlschuurbiers ,

thanks for the review!

Regarding the protocol: If your vocabulary is hosted under http it should also work, but since this is not recommended and https is the standard nowadays, your protocol and server should reflect this.

I don't think the logo error is related to this and therefore I will now resolve conflicts and then merge.

If the error persists, open an issue. The logo should live in static/img/

@sroertgen sroertgen merged commit 14ad489 into main Oct 24, 2023
2 checks passed
@sroertgen sroertgen deleted the 271-custom-domains branch October 24, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support custom domains
2 participants