-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for release of skorch v0.12.0 #902
Conversation
We had a change in the signature of on_batch_begin and on_batch_end. Therefore, we tried to detect if users had overridden these methods and issued a (hopefully) helpful warning. This change is now established long enough that we can remove the warning and associated tests.
proposed release text: We're pleased to announce a new skorch release, bringing new features that might interest you. The main changes relate to better integration with the Hugging Face ecosystem:
But this is not all. We have added the possibility to load the best model parameters at the end of training when using the As always, this release was made possible by outside contributors. Many thanks to:
Find below the list of all changes: Added
Changed
Fixed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As for the release notes, there is no migration guide in the FAQ for going from 0.11 to 0.12. Specifically the following does not link to a section: https://skorch.readthedocs.io/en/stable/user/FAQ.html#migration-from-0-11-to-0-12
Yes, but as soon as we release, the stable docs should be updated and the link should work. |
Changes:
Bump version
Update CHANGES.md
Remove warning about signature change in on_batch methods
We had a change in the signature of
on_batch_begin
andon_batch_end
.Therefore, we tried to detect if users had overridden these methods and
issued a (hopefully) helpful warning.
This change is now established long enough that we can remove the
warning and associated tests.
Release text
@ottonemo and I are working on it, will paste it once it's ready.