Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback after update not appearing #519

Closed
tdb3 opened this issue Nov 27, 2024 · 3 comments
Closed

Feedback after update not appearing #519

tdb3 opened this issue Nov 27, 2024 · 3 comments

Comments

@tdb3
Copy link
Contributor

tdb3 commented Nov 27, 2024

Settings Page, Update Firmware and Update Website forms.

When uploading a new firmware file (e.g. ), the page shows a Working... overlay, then appears to show no feedback of the completion status of the update (i.e. success or failure). This was tested using Firefox and Chrome.

Looks like there is code for this, but the Toasts weren't observed.

this.toastrService.success('Website updated', 'Success!');
window.location.reload();
}, 1000);
} else {
this.toastrService.error(event.statusText, 'Error');
}
}
else if (event instanceof HttpErrorResponse)
{
this.toastrService.error(event.error, 'Error');
}
},
error: (err) => {
this.toastrService.error(err.error, 'Error');

Running developer tools showed:
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Settings page
  2. Click Browse in the Update Website form
  3. Select www.bin

Expected behavior
Feedback is provided to the user.

Hardware:

  • Bitaxe HW version: Supra 401
  • ESP-Miner FW version: master (29a543d)
  • Hash Frequency: N/A for issue
  • Voltage: N/A for issue
  • Pool URL, Port, User: N/A for issue
@tdb3
Copy link
Contributor Author

tdb3 commented Nov 27, 2024

Looks like the intent of the existing code is to reload the page after www.bin update, which would be prudent (to force the user to use the new web UI rather than the client-side code remnant of the UI pre-update). Doesn't appear that this reload is occurring.

@skot
Copy link
Owner

skot commented Nov 30, 2024

If we don't have to restart the ESP32 to reload the page, that works too!

@tdb3
Copy link
Contributor Author

tdb3 commented Dec 1, 2024

#521 fixes the issue (and provides a nice percentage status while waiting!)

@tdb3 tdb3 closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants