Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update feedback & reset file input #521

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Nov 27, 2024

Description

@mrv777 mrv777 changed the title fix: web update feedback fix: update feedback & reset file input Nov 27, 2024
@skot skot merged commit a5f6af1 into skot:master Nov 28, 2024
1 check passed
@tdb3
Copy link
Contributor

tdb3 commented Nov 30, 2024

Post merge test results:

  • Attempting to use a dummy.bin file for either firmware or website resulted in an error toast (expected)
  • 2nd attempt to browse now works well (able to select file)
  • Updated firmware with esp-miner.bin. Observed the percentage completion (nice!). Received the success toast.
  • Updated website with www.bin. Observed the percentage completion. Received the success toast and the page refreshed

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants