Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overheat button and change loading service #364

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Add overheat button and change loading service #364

merged 5 commits into from
Oct 10, 2024

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Sep 28, 2024 •
edited
Loading

  1. Change the overheat checkbox to a button
  2. Improves error handling when loading data
  3. Simplifies the loading service

Screenshot

@mrv777
Copy link
Contributor Author

mrv777 commented Sep 28, 2024

If @benjamin-wilson can just review the loading service change that would great. I noticed it wasn't handling errors properly it seemed, I made a change but then AI seemed to have a much cleaner change that still seemed to work for me and looks nicer

@WantClue WantClue added enhancement New feature or request design Design Enhancements labels Oct 3, 2024
eandersson
eandersson reviewed Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@eandersson eandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it YET, but looks good.

@skot
Copy link
Owner

skot commented Oct 9, 2024

@mrv777 when you get a chance can you rebase this on master? I'd love to get this merged in.

@mrv777
Copy link
Contributor Author

mrv777 commented Oct 9, 2024

@skot rebased. I didn't get to test it with the updated base against a device though

@skot
Copy link
Owner

skot commented Oct 10, 2024

This is looking great!
image
image

@skot
Copy link
Owner

skot commented Oct 10, 2024

I also checked out OTA firmware updates in AP mode -- looks good.

@skot skot merged commit 1a4015f into skot:master Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eandersson eandersson eandersson left review comments

@WantClue WantClue WantClue approved these changes

Assignees
No one assigned
Labels
design Design Enhancements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrv777 @skot @eandersson @WantClue