fix: Better restart feedback & attempt to fix CORS #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eandersson
reviewed
Nov 5, 2024
main/http_server/http_server.c
Outdated
| // Set CORS headers | ||
| if (set_cors_headers(req) != ESP_OK) { | ||
| httpd_resp_send_500(req); | ||
| return ESP_FAIL; |
There was a problem hiding this comment.
Not that I believe we would ever fail to set cors, but I believe you always need to return ESP_OK when intending to send a response to the client e.g. HTTP 500.
See #424
There was a problem hiding this comment.
Okay, so should I change that. Sorry, I'm not very familiar with the ESP code
There was a problem hiding this comment.
Yep. I think this is largely undocumented.
There was a problem hiding this comment.
Okay, I copied and pasted that from the other functions, so I updated them all to return ESP_OK. Let me know if that's an issue, but figured they should all do that then
eandersson
approved these changes
Nov 5, 2024
eandersson
force-pushed
the
swarm-restart
branch
from
c865a29 to
2046719
Compare
WantClue
approved these changes
Nov 9, 2024
WantClue
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should address #154