fix: correct json_rpc_buffer initialization order #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performs memset after checking if the malloc was successful. Safer, avoids segfault on (unlikely) unsuccessful malloc, and allows the error printing to occur.
eandersson
approved these changes
Nov 16, 2024
| if (json_rpc_buffer == NULL) { | ||
| printf("Error: Failed to allocate memory for buffer\n"); | ||
| exit(1); | ||
| } | ||
| memset(json_rpc_buffer, 0, BUFFER_SIZE); |
There was a problem hiding this comment.
LGTM for future proofing.
skot
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #471, noticed that
json_rpc_bufferinitialization tries tomemsetbefore checking if themallocwas successful.This moves the
memsetafter the check.Did a basic test by building and running on a Supra 401. Started mining on testnet4 on a ckpool instance. Jobs were received and shares were accepted.
Note: The malloc failure is unlikely to occur, so we're not seeing an issue now, but if it does occur (e.g. other future code changes chew up too much heap), then we could actually see the error in the log.