LVGL All The Things! #539

mutatrum · 2024-12-01T12:36:39Z

Combined PR for the LVGL implementation. For the bare bones implementation of LVGL alone, please have a look at #434 first. This PR pushes it a lot further, by leveraging LVGL functionalities and cleanup up a lot of code. Some noticeable:

Long text scrolling labels;
Screen transition animations;
Button click and hold handling;
System task and user input task are gone;

Implementation wise the biggest change is that a lot of data is passed through GLOBAL_STATE, which cleans up a lot of display logic form other places.

Things to do/check:

~~IP address changes;~~ ✅
~~Pool changes, both fallback as well as configuration changes;~~ ✅
~~Block found screen;~~ ✅
~~Invalid ASIC model. When does this happen and what should be displayed?~~ ✅
~~Checking of overheat mode reset is moved to power management task;~~ ✅
~~Show connection screen again if AP mode is enabled;~~ ✅

Fixes skot#299

* Button input handle by LVGL * All screen related code into screen.c * Screen class handles boot, config, logo and carousel * Scrolling long lines * Add live updating stats * Add screen transition animations

…l-all-the-things

Other changes: * self test results, is_screen_active and ip_addr_str in GLOBAL_STATE * Fix long label scrolling * Add callback for long press function

eandersson · 2024-12-01T13:14:50Z

Upgraded my Supra without a screen and it unfortunately didn't come back online. I'll plug in the USB later to get the logs.

eandersson · 2024-12-01T14:41:40Z

I (1364) display: Install panel IO
I (1364) display: Install SSD1306 panel driver
E (1364) i2c.master: I2C transaction unexpected nack detected
E (1374) i2c.master: s_i2c_synchronous_transaction(872): I2C transaction failed
E (1374) i2c.master: i2c_master_transmit(1074): I2C transaction failed
E (1384) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(179): i2c transaction failed
E (1394) lcd_panel.ssd1306: panel_ssd1306_init(147): io tx param SSD1306_CMD_SET_MULTIPLEX failed
E (1404) display: display_init(77): Panel init failed
W (1404) SystemModule: OLED init failed!
I (1414) gpio: GPIO[0]| InputEn: 1| OutputEn: 0| OpenDrain: 0| Pullup: 1| Pulldown: 0| Intr:3 
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.

Core  0 register dump:
PC      : 0x420317b8  PS      : 0x00060d30  A0      : 0x82031836  A1      : 0x3fcb84e0  
0x420317b8: tcp_process at /opt/esp/idf/components/lwip/lwip/src/core/tcp_in.c:886 (discriminator 4)

A2      : 0x00000000  A3      : 0x3fcb8500  A4      : 0x3fcb8504  A5      : 0x00060f23  
A6      : 0x0000005e  A7      : 0x00000000  A8      : 0x00000010  A9      : 0x3fcb84c0  
A10     : 0x00000003  A11     : 0x3fcb8500  A12     : 0x3fcb8504  A13     : 0x00060f23  
A14     : 0x3c0e6168  A15     : 0x0000cdcd  SAR     : 0x00000020  EXCCAUSE: 0x0000001c  
EXCVADDR: 0x00000014  LBEG    : 0x400570e8  LEND    : 0x400570f3  LCOUNT  : 0x00000000  
0x400570e8: memset in ROM
0x400570f3: memset in ROM

mutatrum · 2024-12-01T14:42:45Z

Found the issue. I2C error on panel init stops it from initialising LVGL, which is needed later on.

main/lv_conf.h

main/screen.c

mutatrum · 2024-12-02T09:45:59Z

Upgraded my Supra without a screen and it unfortunately didn't come back online. I'll plug in the USB later to get the logs.

I got the button working without the screen. It does complain a lot on boot:

I (1293) display: Install panel IO
I (1293) display: Install SSD1306 panel driver
E (1293) i2c.master: I2C hardware NACK detected
E (1293) i2c.master: I2C transaction unexpected nack detected
E (1303) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (1303) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (1313) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(193): i2c transaction failed
E (1323) lcd_panel.ssd1306: panel_ssd1306_init(151): io tx param SSD1306_CMD_SET_MULTIPLEX failed
E (1333) display: Panel init failed, no display connected?
I (1333) display: Initialize LVGL
I (1343) LVGL: Starting LVGL task
E (1343) i2c.master: I2C hardware NACK detected
E (1343) i2c.master: I2C transaction unexpected nack detected
E (1353) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (1353) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (1363) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(193): i2c transaction failed
E (1373) lcd_panel.ssd1306: panel_ssd1306_mirror(237): io tx param SSD1306_CMD_MIRROR_X_ON/OFF failed
E (1383) i2c.master: I2C hardware NACK detected
E (1383) i2c.master: I2C transaction unexpected nack detected
E (1393) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (1393) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (1403) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(193): i2c transaction failed
E (1413) lcd_panel.ssd1306: panel_ssd1306_draw_bitmap(196): io tx param SSD1306_CMD_SET_COLUMN_RANGE failed
W (1423) display: No display found.
W (1423) SystemModule: OLED init failed!
I (1433) input: Install button driver
I (1433) gpio: GPIO[0]| InputEn: 1| OutputEn: 0| OpenDrain: 0| Pullup: 1| Pulldown: 0| Intr:3

This also means self test succeeds even without a display. It does throw the same errors.

eandersson · 2024-12-02T10:49:14Z

Upgraded my Supra without a screen and it unfortunately didn't come back online. I'll plug in the USB later to get the logs.

I got the button working without the screen. It does complain a lot on boot:

I (1293) display: Install panel IO
I (1293) display: Install SSD1306 panel driver
E (1293) i2c.master: I2C hardware NACK detected
E (1293) i2c.master: I2C transaction unexpected nack detected
E (1303) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (1303) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (1313) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(193): i2c transaction failed
E (1323) lcd_panel.ssd1306: panel_ssd1306_init(151): io tx param SSD1306_CMD_SET_MULTIPLEX failed
E (1333) display: Panel init failed, no display connected?
I (1333) display: Initialize LVGL
I (1343) LVGL: Starting LVGL task
E (1343) i2c.master: I2C hardware NACK detected
E (1343) i2c.master: I2C transaction unexpected nack detected
E (1353) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (1353) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (1363) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(193): i2c transaction failed
E (1373) lcd_panel.ssd1306: panel_ssd1306_mirror(237): io tx param SSD1306_CMD_MIRROR_X_ON/OFF failed
E (1383) i2c.master: I2C hardware NACK detected
E (1383) i2c.master: I2C transaction unexpected nack detected
E (1393) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (1393) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (1403) lcd_panel.io.i2c: panel_io_i2c_tx_buffer(193): i2c transaction failed
E (1413) lcd_panel.ssd1306: panel_ssd1306_draw_bitmap(196): io tx param SSD1306_CMD_SET_COLUMN_RANGE failed
W (1423) display: No display found.
W (1423) SystemModule: OLED init failed!
I (1433) input: Install button driver
I (1433) gpio: GPIO[0]| InputEn: 1| OutputEn: 0| OpenDrain: 0| Pullup: 1| Pulldown: 0| Intr:3

This also means self test succeeds even without a display. It does throw the same errors.

Complaining is fine, as long as it does not spam (or even worse impact performance) after boot is done.

mutatrum · 2024-12-02T11:03:26Z

Complaining is fine, as long as it does not spam (or even worse impact performance) after boot is done.

No, it only complains at boot. All screen handling and updating is done in an lv_timer, which is not started if the display is not attached.

ESP-Miner/main/screen.c

Lines 306 to 317 in 78ec3c8

    
           if (GLOBAL_STATE->SYSTEM_MODULE.is_screen_active) { 
        
               SystemModule * module = &GLOBAL_STATE->SYSTEM_MODULE; 
        
               screens[SCR_SELF_TEST] = create_scr_self_test(); 
        
               screens[SCR_OVERHEAT] = create_scr_overheat(module); 
        
               screens[SCR_CONFIGURE] = create_scr_configure(module); 
        
               screens[SCR_CONNECTION] = create_scr_connection(module); 
        
               screens[SCR_LOGO] = create_scr_logo(); 
        
               screens[SCR_URLS] = create_scr_urls(module); 
        
               screens[SCR_STATS] = create_scr_stats(); 
        
               lv_timer_create(screen_update_cb, SCREEN_UPDATE_MS, NULL);

main/display.c

mutatrum added 18 commits November 18, 2024 14:01

Implement LVGL 8.4

148f454

Fixes skot#299

Add font attribution

7fd5be9

Add missing values in sdkconfig.defaults

6cadf46

Fix crash when screen is not present

7b5bda2

Revert SPIRAM enable

f3e6dd7

Revert use of idf.py save-defconfig

c395648

Use custom lv_conf.h

6d29557

Merge branch 'skot:master' into lvgl

ea4ea36

Port to LVGL 9 with esp_lvgl_port patch version

5adbe52

Merge branch 'master' into lvgl

84e2ee8

LVGL all the things!

6397fa4

* Button input handle by LVGL * All screen related code into screen.c * Screen class handles boot, config, logo and carousel * Scrolling long lines * Add live updating stats * Add screen transition animations

Bump esp_lvgl_port to 2.4.3

03610bb

Merge branch 'master' into lvgl

fea4f01

Fix missing include

06d048c

Merge branch 'lvgl' of https://github.com/mutatrum/ESP-Miner into lvg…

378e913

…l-all-the-things

Merge branch 'master' into lvgl

08930e5

Merge branch 'lvgl' into lvgl-all-the-things

aa85011

Adapt self_test to lvgl code

6238a3b

Other changes: * self test results, is_screen_active and ip_addr_str in GLOBAL_STATE * Fix long label scrolling * Add callback for long press function

mutatrum mentioned this pull request Dec 1, 2024

Implement LVGL #434

Closed

WantClue reviewed Dec 1, 2024

View reviewed changes

main/lv_conf.h Outdated Show resolved Hide resolved

WantClue reviewed Dec 1, 2024

View reviewed changes

main/screen.c Outdated Show resolved Hide resolved

Remove camelcase from Bitaxe

c0263de

mutatrum added 4 commits December 2, 2024 10:49

Fix crash when display is not present

183789f

Make a minimal lv_conf.h

03e08e4

Add callback to button short click

ff1a4be

Don't divide by zero on boot

7768004

Add found block to stats screen

cef9b3f

Whitespace

78ec3c8

mutatrum added 6 commits December 2, 2024 12:07

Merge branch 'master' into lvgl-all-the-things

4692931

Fix screen noise on boot

9ddfd96

Add screen for invalid ASIC

f350993

Fix label reference

b1244e2

Fix missing reference

d8f26ce

Merge branch 'master' into lvgl-all-the-things

648c229

WantClue added enhancement New feature or request design Design Enhancements labels Dec 2, 2024

mutatrum added 3 commits December 3, 2024 08:45

Merge branch 'master' into lvgl-all-the-things

a176ded

Merge branch 'master' into lvgl-all-the-things

1a7ec7c

Fix ip address on overheat and minig url fallback

1cf7df3

WantClue approved these changes Dec 10, 2024

View reviewed changes

mutatrum added 5 commits December 10, 2024 15:41

Add wifi status to screen

8efc3fd

Switch back to connection screen if AP is enabled.

922aad1

Add comment with ref to wifi error reason codes

943bc40

Missing commit

efb095e

Fix connection screen on startup

73897c9

WantClue reviewed Dec 11, 2024

View reviewed changes

main/display.c Show resolved Hide resolved

WantClue approved these changes Dec 11, 2024

View reviewed changes

eandersson approved these changes Dec 11, 2024

View reviewed changes

WantClue merged commit 848c780 into skot:master Dec 11, 2024
1 check passed

mutatrum deleted the lvgl-all-the-things branch December 11, 2024 22:21

This was referenced Dec 12, 2024

First time setup - Change the message on OLED #447

Open

Switch to a proper LCD library for the OLED #299

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LVGL All The Things! #539

LVGL All The Things! #539

mutatrum commented Dec 1, 2024 •

edited

Loading

eandersson commented Dec 1, 2024

eandersson commented Dec 1, 2024

mutatrum commented Dec 1, 2024

mutatrum commented Dec 2, 2024 •

edited

Loading

eandersson commented Dec 2, 2024

mutatrum commented Dec 2, 2024

LVGL All The Things! #539

LVGL All The Things! #539

Conversation

mutatrum commented Dec 1, 2024 • edited Loading

eandersson commented Dec 1, 2024

eandersson commented Dec 1, 2024

mutatrum commented Dec 1, 2024

mutatrum commented Dec 2, 2024 • edited Loading

eandersson commented Dec 2, 2024

mutatrum commented Dec 2, 2024

mutatrum commented Dec 1, 2024 •

edited

Loading

mutatrum commented Dec 2, 2024 •

edited

Loading