test: add boundary check for implicit response method

[tdb3]

Looks like #192 introduced changes to the stratum_method enum that causes failures in the unit tests added a week prior in #163. This PR adjusts adjusts the tests and makes them more descriptive to test the boundary condition in

ESP-Miner/components/stratum/stratum_api.c

Lines 155 to 169 in 468718a

	} else if (!cJSON_IsNull(error_json)) {
	if (parsed_id < 5) {
	result = STRATUM_RESULT_SETUP;
	} else {
	result = STRATUM_RESULT;
	}
	message->response_success = false;
	//if the result is a boolean, then parse it
	} else if (cJSON_IsBool(result_json)) {
	if (parsed_id < 5) {
	result = STRATUM_RESULT_SETUP;
	} else {
	result = STRATUM_RESULT;
	}

Tested by flashing unit_test_stratum.bin and monitoring test logging:

Running Parse stratum result success...
/home/dev/myrepos/ESP-Miner/components/stratum/test/test_stratum_json.c:118:Parse stratum result success:PASS
...
Running Parse stratum result error...
/home/dev/myrepos/ESP-Miner/components/stratum/test/test_stratum_json.c:155:Parse stratum result error:PASS

[eandersson]

Unrelated to the PR itself but could you add a guide on how to run the unit tests locally?

[tdb3]

Unrelated to the PR itself but could you add a guide on how to run the unit tests locally?

Added a unit test guide in #549

[eandersson]

Unrelated to the PR itself but could you add a guide on how to run the unit tests locally?

Added a unit test guide in #549

Perfect thanks. I'll try to check it out tomorrow.

[WantClue]

@tdb3 please resolve conflicts

[tdb3]

Thanks for pinging. Update pushed. Needed to rebase on top of commit f454b0c due to Issue #607. Merge conflict should be alleviated.

idf.py -p /dev/ttyACM0 monitor
...
Running Parse stratum result success...
/home/dev/myrepos/ESP-MinerAlt/ESP-Miner/components/stratum/test/test_stratum_json.c:118:Parse stratum result success:PASS
...
Running Parse stratum result error...
/home/dev/myrepos/ESP-MinerAlt/ESP-Miner/components/stratum/test/test_stratum_json.c:155:Parse stratum result error:PASS

Also fixes a bug in the test that used TEST_ASSERT_EQUAL instead of TEST_ASSERT_EQUAL_STRING for string checking.