-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device_tracker_timeout example config #612
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
README.md (1)
439-442
: Consider adjusting comment formatting for consistency.The comment formatting could be improved to match the style of other configuration options in the file:
- # By adjusting device_tracker_timeout , users can determine how long they - # want to wait before receiving a 'not_home' message when no person is - # recognized. The time delay is implemented in minutes and the default value - # is set to 30 minutes + # By adjusting device_tracker_timeout, users can determine how long they + # want to wait before receiving a 'not_home' message when no person is + # recognized. The time delay is implemented in minutes and the default value + # is set to 30 minutes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
README.md
(1 hunks)
🔇 Additional comments (1)
README.md (1)
436-444
: LGTM! Configuration option correctly placed under frigate
section.
The device_tracker_timeout
option is now properly documented and correctly placed at the root level of the frigate
configuration section, which matches how it's used in the codebase.
Fix indentation of
device_tracker_timeout
property in example config in README.As you can see from the relevant code below,
device_tracker_timeout
is not nested inside theevents
property:Summary by CodeRabbit
New Features
device_tracker_timeout
, allowing users to customize the delay for the MQTT home assistant device tracker.Documentation
README.md
to include the new configuration option and improved clarity of comments related to its purpose and default value.