-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Little details #46
Little details #46
Conversation
Sice it's an SVG and its a square, needs always the same value for width and height.
Allow to customize more the gh-corner like: ``` <GithubCorner href={githubUrl} style={{ 'mixBlendMode': 'darken' }}/> ``` to made the octocat trasnparent. Details in [this issue](tholman/github-corners#15).
Looks good to me. Thanks for taking an interest and the time to submit a PR! The react-github-corner/src/app/pages/Home.js Lines 72 to 73 in da73ec4
We also need to fix the README: https://github.com/skratchdot/react-github-corner/blame/master/README.md#L49-L50 Basically, anywhere that width/height exist in this repo would need to be fixed. |
Will update each place where reference |
Awesome! Thanks for making these additional changes. |
@elrumordelaluz - One thing I noticed after pulling this down and running locally: i had a test that was using "style" to set the style on the outside anchor tag. I think I'm going to rename the new "style" property you added to "svgStyle". Once I do that, I'll bump the major version and publish this on npm. Thanks again. |
Just published version |
Unify keyframes with same value
Unify
size
props (in case will updateREADME
). Adds also aPropTypes.oneOfType
to avoid warning when using aString
and match the DocumentationAdds
style
prop to pass and apply to the mainSVG
allowing to make the octocat transparent, for exampleMore use-cases in this issue from the original repo